1390068 - Define Symbol.toPrimitive on NPObjectMember instead of using a getProperty hook

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Like bug 1389949, but this one is much simpler: instead of using a getProperty hook to return a function for Symbol.toPrimitive, we should just define this property when we create the NPObjectMember object.

Note that we have tests that rely on this (test_propertyAndMethod.html) and they pass with this patch.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 2

[Tom S. (please needinfo tschuster)]

Comment on attachment 8896911 [details] [diff] [review]
Patch

Review of attachment 8896911 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds sensible, using a getProperty hook for this wasn't really necessary.

::: dom/plugins/base/nsJSNPRuntime.cpp
@@ +2202,5 @@
> +    return false;
> +
> +  JS::Rooted<JS::Value> val(cx, JS::ObjectValue(*JS_GetFunctionObject(fun)));
> +
> +  if (!JS_DefinePropertyById(cx, memobj, toPrimitiveId, val, 0))

I think DefinePropertyById has an object overload.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/030afe238ba3
Define Symbol.toPrimitive property when creating NPObjectMember instead of using a getProperty hook. r=evilpie

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/030afe238ba3