Closed Bug 1390073 Opened 3 years ago Closed 3 years ago

Indent suite manifest file statements

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set

Tracking

(seamonkey2.54 fixed)

RESOLVED FIXED
seamonkey2.54
Tracking Status
seamonkey2.54 --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1295826 +++

When discussing bug 1295826 over irc ewong and frg decided to align the indention of the statements in the config manifest files with TB and Fx.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8896916 - Flags: review?(ewong)
No longer depends on: 1343800
Comment on attachment 8896916 [details] [diff] [review]
1390073-manifestindention.patch

Review of attachment 8896916 [details] [diff] [review]:
-----------------------------------------------------------------

aside for the nits, lgtm.

::: suite/config/tooltool-manifests/linux32/releng.manifest
@@ +2,5 @@
> +  {
> +    "version": "gcc 4.9.4 + PR64905",
> +    "size": 101297752,
> +    "digest": "42aa2e3fdd232b5e390472a788e7f7db71a1fee4221e260b6cb58c9a1d73e6cdd10afcbac137f7844290169cd6b561b424ecc92b159e9726b0ad5de3f478a8be",
> +    "algorithm": "sha512", 

trailing whitespace nit.

::: suite/config/tooltool-manifests/linux64/releng.manifest
@@ +2,5 @@
> +  {
> +    "version": "gcc 4.9.4 + PR64905",
> +    "size": 101297752,
> +    "digest": "42aa2e3fdd232b5e390472a788e7f7db71a1fee4221e260b6cb58c9a1d73e6cdd10afcbac137f7844290169cd6b561b424ecc92b159e9726b0ad5de3f478a8be",
> +    "algorithm": "sha512", 

there's a trailing whitespace.
Attachment #8896916 - Flags: review?(ewong) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/12e3209b88ba
Indent statements in manifest files for SeaMonkey. r=ewong
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.54
You need to log in before you can comment on or make changes to this bug.