Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bevis, Assigned: bevis)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

The timer used by ImageCache internally (inside nsExpirationTracker inherited by ImageCache) is shown up recently in the top unlabeled runnable list:
https://gist.github.com/bevis-tseng/12cf108f681467ca7d8f3088db4eb584

The possible way to label this tracker is to pass the SystemGroup as the event target when calling nsExpirationTracker's ctor if ImageCache::NotifyExpired() doesn't touch any JS callback of a web content.
Hi Mason,

To have more benefit from qDOM scheduling, I'd like to mark the tracker of ImageCache with SystemGroup in the assumption that the NotifyExpired() doesn't touch any JS of the web content.
May I have your review for this change?

The test result in try looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b41930e77654639b9c495c64acc358033a61bf63
Assignee: nobody → btseng
Attachment #8897302 - Flags: review?(mchang)
Attachment #8897302 - Flags: review?(mchang) → review+

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/77039c440373
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.