Closed
Bug 1390080
Opened 7 years ago
Closed 7 years ago
Label ImageCache
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
mchang
:
review+
|
Details | Diff | Splinter Review |
The timer used by ImageCache internally (inside nsExpirationTracker inherited by ImageCache) is shown up recently in the top unlabeled runnable list: https://gist.github.com/bevis-tseng/12cf108f681467ca7d8f3088db4eb584 The possible way to label this tracker is to pass the SystemGroup as the event target when calling nsExpirationTracker's ctor if ImageCache::NotifyExpired() doesn't touch any JS callback of a web content.
|
Assignee | |
Comment 1•7 years ago
|
||
Hi Mason, To have more benefit from qDOM scheduling, I'd like to mark the tracker of ImageCache with SystemGroup in the assumption that the NotifyExpired() doesn't touch any JS of the web content. May I have your review for this change? The test result in try looks fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b41930e77654639b9c495c64acc358033a61bf63
Assignee: nobody → btseng
Attachment #8897302 -
Flags: review?(mchang)
|
||
Updated•7 years ago
|
Attachment #8897302 -
Flags: review?(mchang) → review+
Pushed by btseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/77039c440373 Label ImageCache.
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/77039c440373
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•