Closed Bug 1390109 Opened 2 years ago Closed 2 years ago

OOM crash in mozilla::image::ImageSurfaceCache::Insert

Categories

(Core :: ImageLib, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

(Keywords: crash, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

Mostly happens on x86 platforms, a few hundred crashes in the last 3 months across many versions.

https://crash-stats.mozilla.com/report/index/13277c99-6993-4f96-a924-c6fd50170814

Simple enough to handle this case and not crash since we already have the plumbing to do it.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Crash Signature: [@ OOM | unknown | NS_ABORT_OOM | mozilla::image::ImageSurfaceCache::Insert ] [@ OOM | unknown | NS_ABORT_OOM | nsBaseHashtable<T>::Put | mozilla::image::ImageSurfaceCache::Insert ] [@ PLDHashTable::Add | nsBaseHashtable<T>::Put | mozilla::image::ImageS…
Keywords: crash
Priority: -- → P3
Whiteboard: [gfx-noted]
Attachment #8896946 - Flags: review?(tnikkel)
Attachment #8896946 - Flags: review?(tnikkel) → review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5ad60345270
Gracefully propogate ImageSurfaceCache::Insert OOM failures to SurfaceCache::Insert. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/a5ad60345270
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Crash volume doesn't seem worth backporting to me. Feel free to set the status back to affected and nominate for approval if you feel otherwise, however.
You need to log in before you can comment on or make changes to this bug.