1390168 - [traceback] TypeError: socorro.processor.breakpad_transform_rules in _predicate in JitCrashCategorizationRule

Status: RESOLVED FIXED

(Socorro :: Processor, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Traceback:

"""
TypeError: 'NoneType' object has no attribute '__getitem__'
  File "socorro/lib/transform_rules.py", line 112, in predicate
    return self._predicate(*args, **kwargs)
  File "socorro/processor/breakpad_transform_rules.py", line 671, in _predicate
    processed_crash.json_dump['crashing_thread']['frames'][0].get(
"""

This is in the JitCrashCategorizationRule. Sentry says there are 46 of these in the last 6 days.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

In sentry: https://sentry.prod.mozaws.net/operations/socorro-prod/issues/604604/

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to fix today.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 3930 - add defensive code to JitCrashCategorizationRule

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/bbaa034291a4de14e56a7378bb5bc47d95e83c67
fixes bug 1390168 - add defensive programming to JitCrashCategorizeRule (#3930)

* tweak the code so it's less fragile regarding what's in json_dump
* rewrite the original test_no_crashing_thread test so it's more minimal
* add a bunch more tests covering other data scenarios, too