1390177 - Remove background change on hover

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: blue-background on hover

When you hover a message in the console, the background turns into a light blue background. Now, if you have an expanded object which takes a certain height of the console, the hover background is not helpful at all and makes it slightly harder to parse the object.

The background should be removed in favor of something else.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: left-border on hover

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1390177 - Change message hover style. .

This removes the blue-background on hover which mades the
messages hard to read, to a 2px left-colored border.

Review commit: https://reviewboard.mozilla.org/r/168328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168328/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8897762 [details]
Bug 1390177 - Change message hover style. .

https://reviewboard.mozilla.org/r/168328/#review174528

::: devtools/client/themes/webconsole.css:767
(Diff revision 1)
> +  --border-size: 3px;
> +  border-inline-start: var(--border-size) solid transparent;
> +}
> +
> +.webconsole-output-wrapper .message:hover {
> +  background-color: transparent !important;

This ends up overriding the background color for error messages (ie on http://bgrins.github.io/devtools-demos/console/errors.html).

I'd prefer to remove the original hover styling (https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/webconsole.css#220-222) along with this line.  I'm not too worried about dropping the hover from the old UI, I don't think it's providing a lot of help. Don't worry about getting the hover border working in the old UI, either.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8897762 [details]
Bug 1390177 - Change message hover style. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168328/diff/1-2/

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8897762 [details]
Bug 1390177 - Change message hover style. .

https://reviewboard.mozilla.org/r/168328/#review175118

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a206b95067
Change message hover style. r=bgrins.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88a206b95067