Closed Bug 1390263 Opened 2 years ago Closed 2 years ago

return NS_OK on expected sleep-wake notification in PresShell::Observe

Categories

(Core :: Layout, enhancement)

49 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: chutten, Assigned: wcpan)

References

Details

(Whiteboard: [good first bug][lang=c++])

Attachments

(1 file)

bug 1357742 asked PresShell to listen for sleep wake notifications, but didn't return NS_OK after handling it.

This was a mistake.

A fix is to add return NS_OK; after this line: http://searchfox.org/mozilla-central/rev/6482c8a5fa5c7446e82ef187d1a1faff49e3379e/layout/base/PresShell.cpp#9731
Component: General → Layout
Product: Firefox → Core
Steal this bug because this can block bug 1373814.
Assignee: nobody → wpan
Comment on attachment 8898222 [details]
Bug 1390263 - Follow up for Bug 1357742.

https://reviewboard.mozilla.org/r/169578/#review174838

Looks fine to me.
Attachment #8898222 - Flags: review?(xidorn+moz) → review+
https://hg.mozilla.org/mozilla-central/rev/bad9d2d416fa
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.