Closed
Bug 1390263
Opened 9 years ago
Closed 9 years ago
return NS_OK on expected sleep-wake notification in PresShell::Observe
Categories
(Core :: Layout, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: chutten, Assigned: wcpan)
References
Details
(Whiteboard: [good first bug][lang=c++])
Attachments
(1 file)
bug 1357742 asked PresShell to listen for sleep wake notifications, but didn't return NS_OK after handling it.
This was a mistake.
A fix is to add return NS_OK; after this line: http://searchfox.org/mozilla-central/rev/6482c8a5fa5c7446e82ef187d1a1faff49e3379e/layout/base/PresShell.cpp#9731
|
||
Updated•9 years ago
|
Component: General → Layout
Product: Firefox → Core
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•9 years ago
|
||
Steal this bug because this can block bug 1373814.
Assignee: nobody → wpan
|
||
Comment 3•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8898222 [details]
Bug 1390263 - Follow up for Bug 1357742.
https://reviewboard.mozilla.org/r/169578/#review174838
Looks fine to me.
Attachment #8898222 -
Flags: review?(xidorn+moz) → review+
Pushed by wpan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bad9d2d416fa
Follow up for Bug 1357742. r=xidorn
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•