Closed Bug 1390264 Opened 3 years ago Closed 3 years ago
Hovering over pocket icon in popup window causes the URL bar to shift
See attached video. If you hover over the pocket icon in a popup window, the url bar shifts.
Which nightly is this? What version of OS X? Does this reproduce with servo/stylo disabled? How about safe mode? Clean profile with a popup that isn't from a logged-in gmail session ( I find running this in a web console helpful: document.body.addEventListener("click", () => window.open("", "_blank", "height=200")) ) ? This could be a frontend issue, but equally looks like something that might be a graphics/layout issue. It'd help if we could narrow this down further, but for now, I can't quickly repro on my own OS X nightly (today, osx 10.12.6)
Ah, never mind, I need an actual URL in the window, about:blank doesn't do.
Could this be from bug 1389740?
Jared, this seems to be happening because the animatable box unhides on :hover. Any idea what's up?
(In reply to Johann Hofmann [:johannh] from comment #3) > Could this be from bug 1389740? Or that. They both landed in the same nightly, from different branches, so that was fun... (x-ref bug 1390182 as well)
See Also: → 1390182
We unhide it on :hover to preload the animation. We shouldn't do this in windows with chromehidden because the toolbar won't have position:relative.
I can reproduce this on latest Linux Nightly, 57.0a1 (2017-08-14) (64-bit). This is specific to the Pocket icon -- it does not happen with the bookmark or "..." icons. STR: 1. Compose an email message in Gmail. 2. Shift-click the diagonal-expanding-arrows icon at the top right of your compose-new-message pane. (This should pop out a smaller dialog for your email message.) 3. Hover the pocket icon in the (non-editable) URL bar for that smaller window. ACTUAL RESULTS: The entire contents of the URL bar shift upwards by several pixels. The .../star/pocket icons at the right side shift slightly leftwards, too.
Confirmed regression from Bug 1387077 (not bug 1389740). Confirmed that range using mozregression. Regression range (single commit): https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1a8d86baaabc1af9d2359a0f078a9ee50aec9351&tochange=c9bc6af2793a6e5fc9a6a6c588ebdd8b1f44f876
Priority: -- → P3
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8897972 [details] Bug 1390264 - Only set up the pocket-animatable-box when animation should begin. https://reviewboard.mozilla.org/r/169282/#review174640
Attachment #8897972 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1770d65a3428 Only set up the pocket-animatable-box when animation should begin. r=Gijs
Flags: qe-verify? → qe-verify+
QA Contact: stefan.georgiev
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID 20170830100230 This bug fix is Verified with latest Nightly 57.0a1.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.