The "Sign in to Sync" menuitem does nothing in a popup window

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mkaply, Assigned: eoger)

Tracking

Trunk
Firefox 57
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
If you open a popup window (easiest way is gmail - compose, hold shift for the popout) and then select "Sign in to sync", nothing happens. It should open the sync login in the main window.
(Reporter)

Comment 1

2 years ago
Other menu items that don't work:

Library->Bookmarks->view bookmarks sidebar
Library->History->view history sidebar
(Reporter)

Updated

2 years ago
Blocks: 1015163
Comment hidden (obsolete)
Comment hidden (obsolete)

Comment 4

2 years ago
(In reply to :Gijs from comment #3)
> (In reply to :Gijs from comment #2)
> > (In reply to Mike Kaply [:mkaply] from comment #1)
> > > Other menu items that don't work:
> > > 
> > > Library->Bookmarks->view bookmarks sidebar
> > > Library->History->view history sidebar
> > 
> > File 1 separate bug for these 2 things, please. It's unrelated to sync.
> 
> +ni

Actually, scratch that - this is just bug 375679 and bug 594797.
Flags: needinfo?(mozilla)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 years ago
Confirmed with rfeeley that the hamburger menu appearing in popups is normal.
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 7

2 years ago
mozreview-review
Comment on attachment 8897546 [details]
Bug 1390273 - Initialize the Sync UI in popup windows.

https://reviewboard.mozilla.org/r/168808/#review174204

Per bug 965607 this will also show doorhangers when syncing fails etc., and we should avoid doing that in popup windows. Should we re-add the check somewhere else?
Attachment #8897546 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Comment 8

2 years ago
We don't do doorhangers anymore so this should be fine.

Comment 9

2 years ago
mozreview-review
Comment on attachment 8897546 [details]
Bug 1390273 - Initialize the Sync UI in popup windows.

https://reviewboard.mozilla.org/r/168808/#review174218

OK!
Attachment #8897546 - Flags: review+

Comment 10

2 years ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e4632a2b787
Initialize the Sync UI in popup windows. r=Gijs
(Assignee)

Comment 11

2 years ago
Thanks!

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7e4632a2b787
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Assignee)

Updated

2 years ago
Depends on: 1391042
You need to log in before you can comment on or make changes to this bug.