1390341 - puppet node regex defs needs beginning of string (^) qualifier

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Jake Watkins [:dividehex]]

While rolling out the new firewall puppet framework to signing servers, I noticed the  /signing\d+\.srv\.releng\.(mdc1|scl3)\.mozilla\.com/ regex was picking up and matching to the mac-depsigning hosts in mdc1.  Which means it is missing the real node def /mac-depsigning\d+\.srv\.releng\.(mdc1|scl3)\.mozilla\.com/

As :aki pointed out, this is also probably why we are getting puppet errors on the mac-depsigning hosts to begin with.

We should be more expicit and use a carrot (^) to match only to the beginning of the fqdn string.  And we might also want to do this to ALL the regex node defs.

Comment 1

[Jake Watkins [:dividehex]]

Attachment: add ^ to signing regex node defs

Let's start with signing servers

Comment 2

[Jake Watkins [:dividehex]]

Comment on attachment 8897183 [details] [diff] [review]
add ^ to signing regex node defs

https://hg.mozilla.org/build/puppet/rev/937153f8014730f71b5185eeab958975447a2e6d
https://hg.mozilla.org/build/puppet/rev/16129ae6970271bf6736252fa6486c769d16cae6

Comment 3

[Jake Watkins [:dividehex]]

Attachment: bug1390341-moco-node.patch

This patch goes a little out of scope but I felt like this was a good place to make a big sweeping change to moco-nodes.pp.

The patch does the following:
- adds MDC2 to select node defs that are ready to be kickstarted in MDC2
- adds regex ^ and $ markers to regex node defs (original scope of this bug)
- removed various decommed node defs

:aki, could you check this for any problems or even node defs that could also be removed?

Thanks!

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 8948760 [details] [diff] [review]
bug1390341-moco-node.patch

I think this makes sense.
This is the first I've heard of mdc2!
Hoping to obsolete partner-repack-\d+ by end of Feb.

Comment 5

[Jake Watkins [:dividehex]]

Comment on attachment 8948760 [details] [diff] [review]
bug1390341-moco-node.patch

https://hg.mozilla.org/build/puppet/rev/8995b17f062850c2f820e3b01af405a353cd1e1b
https://hg.mozilla.org/build/puppet/rev/32423130a3b077d47cb1c093fd0cb603b1240ec5