1390394 - Write mochitest to ensure that after setting <input type=file>.files using FormData gets the new files

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Ben Tian (inactive)]

Per bug 1384030 comment 7 and bug 1384030 comment 9.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Mochitest to ensure FormData gets the new files after setting <input type=file>.files

Olli, can you review my mochitest patch that verifies FormData gets the new files after setting <input type=file>.files?

Prior discussion was from bug 1384030 comment 7.

Comment 2

[Olli Pettay [:smaug]]

Comment on attachment 8897789 [details] [diff] [review]
Patch 1 (v1): Mochitest to ensure FormData gets the new files after setting <input type=file>.files

>+  // Assign input1.files to input2.files
>+  input2.files = input1.files;
>+  ok(input2.files.length === 2, "input2.files has incorrect length");
Nit, I'd use is() in this kind of checks

>+
>+  // Append input2.files into FormData
>+  var fd = new FormData();
>+  fd.append("file0", input2.files[0]);
>+  fd.append("file1", input2.files[1]);

Hmm, I wasn't thinking this, but to have type=file elements inside a form element and then do something like 
var fd = new FormData(formElement);
and then check that the FormData has reasonable content.
https://xhr.spec.whatwg.org/#interface-formdata

Sorry if I wasn't clear.

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 1 (v2): Mochitest to ensure FormData gets the new files after setting <input type=file>.files

Revise per reviewer's suggestion.

Comment 4

[Olli Pettay [:smaug]]

Comment on attachment 8898103 [details] [diff] [review]
Patch 1 (v2): Mochitest to ensure FormData gets the new files after setting <input type=file>.files

I wouldn't mind if it was also checked that inputFiles[0] is the same object as the first File create and [1] the second one.
So perhaps something like
is(inputFiles[0], input.files[0], "Expected File object");
is(inputFiles[1], input.files[1], "Expected File object");

Comment 5

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Mochitest to ensure FormData gets the new files after setting <input type=file>.files, r=smaug

Revise per reviewer's comment 4.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddec76e7257b
Mochitest to ensure FormData gets the new files after setting <input type=file>.files. r=smaug

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ddec76e7257b