Closed Bug 1390396 Opened 5 years ago Closed 4 years ago

Reenable mochitests for custom elements lifecycle callbacks

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- wontfix
firefox59 --- fixed

People

(Reporter: jessica, Assigned: edgar)

References

Details

Attachments

(1 file)

We will disable some of the custom element v0-compatible mochitests while implementing v1 lifecycle callbacks. We should reenable them once v1 lifecycle callbacks are completed and change them to v1-compatible.
Priority: -- → P2
v1 lifecycle callbacks are all landed, I think it's time to change disabled mochitests to v1-compatible and reenable them.
Assignee: nobody → echen
Attachment #8928780 - Flags: feedback?(jdai)
Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

I found there is a typo in the previous version, send feedback request again for the new version which fixes the typo.
Attachment #8928780 - Flags: feedback?(jdai)
Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

Looks good to me.
Attachment #8928780 - Flags: feedback?(jdai) → feedback+
Attachment #8928780 - Flags: review?(bugs)
Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

https://reviewboard.mozilla.org/r/200048/#review207338
Attachment #8928780 - Flags: review?(bugs) → review+
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a1ab50128e
Reenable mochitests for custom elements lifecycle callbacks; r=smaug
https://hg.mozilla.org/mozilla-central/rev/b4a1ab50128e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.