1390396 - Reenable mochitests for custom elements lifecycle callbacks

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Jessica Jong [:jessica] (inactive)]

We will disable some of the custom element v0-compatible mochitests while implementing v1 lifecycle callbacks. We should reenable them once v1 lifecycle callbacks are completed and change them to v1-compatible.

Comment 1

[Edgar Chen [:edgar]]

v1 lifecycle callbacks are all landed, I think it's time to change disabled mochitests to v1-compatible and reenable them.

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6727940c8852c839ac330629aee85e47d25cb57d&filter-tier=1&group_state=expanded

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

Review commit: https://reviewboard.mozilla.org/r/200048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200048/

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200048/diff/1-2/

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200048/diff/2-3/

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

I found there is a typo in the previous version, send feedback request again for the new version which fixes the typo.

Comment 7

[John Dai[:jdai]]

Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

Looks good to me.

Comment 8

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a444b69bba88&group_state=expanded&filter-tier=1

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8928780 [details]
Bug 1390396 - Reenable mochitests for custom elements lifecycle callbacks;

https://reviewboard.mozilla.org/r/200048/#review207338

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a1ab50128e
Reenable mochitests for custom elements lifecycle callbacks; r=smaug

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b4a1ab50128e