Closed Bug 1390424 Opened 2 years ago Closed 2 years ago

Label PContent::Msg_ParentActivated

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

Details

Attachments

(1 file, 2 obsolete files)

This IPC message contains PBrowser object.
We could reuse utilize this PBrowser to label this message with its corresponding TabGroup.
Label these 3 IPC messages using the TabGroup of the PBrowserChild instance retrieved from the IPC messages.

Treeherder result looks fine so far:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=08ac306a0bd1b14be1226dc4e8868a648d865d29
Attachment #8897341 - Flags: review?(wmccloskey)
Comment on attachment 8897341 [details] [diff] [review]
(v1) Patch: Label PContent::Msg_{Activate|Deactivate|ParentActivated}

Review of attachment 8897341 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, we hit Assertion failure: IsSafeToRun() at RecvActivate()
GECKO(1095) | Assertion failure: IsSafeToRun(), at /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/SchedulerGroup.h:81
GECKO(1095) | #01: mozilla::dom::DocGroup::ValidateAccess [xpcom/threads/SchedulerGroup.h:81]
GECKO(1095) | #02: nsDocument::GetEventTargetParent [dom/base/nsDocument.cpp:8049]
GECKO(1095) | #03: mozilla::EventTargetChainItem::GetEventTargetParent [dom/events/EventDispatcher.cpp:211]
GECKO(1095) | #04: mozilla::EventDispatcher::Dispatch [dom/events/EventDispatcher.cpp:751]
GECKO(1095) | #05: FocusBlurEvent::Run [dom/base/nsFocusManager.cpp:2051]
GECKO(1095) | #06: nsContentUtils::AddScriptRunner [dom/base/nsContentUtils.cpp:5741]
GECKO(1095) | #07: nsContentUtils::AddScriptRunner [dom/base/nsContentUtils.cpp:5748]
GECKO(1095) | #08: nsFocusManager::FireFocusOrBlurEvent [dom/base/nsFocusManager.cpp:2235]
GECKO(1095) | #09: nsFocusManager::SendFocusOrBlurEvent [dom/base/nsFocusManager.cpp:2154]
GECKO(1095) | #10: nsFocusManager::Blur [dom/base/nsFocusManager.cpp:1784]
GECKO(1095) | #11: nsFocusManager::WindowLowered [dom/base/nsFocusManager.cpp:810]
GECKO(1095) | #12: nsFocusManager::WindowRaised [dom/base/nsFocusManager.cpp:706]
GECKO(1095) | #13: nsWebBrowser::Activate [toolkit/components/browser/nsWebBrowser.cpp:1826]
GECKO(1095) | #14: mozilla::dom::TabChild::RecvActivate [ipc/glue/ProtocolUtils.h:247]
GECKO(1095) | #15: mozilla::dom::ContentChild::RecvActivate [dom/ipc/ContentChild.cpp:3448]
GECKO(1095) | #16: mozilla::dom::PContentChild::OnMessageReceived [obj-firefox/ipc/ipdl/PContentChild.cpp:7882]
Attachment #8897341 - Flags: review?(wmccloskey) → review-
It's too greedy to label these 3 focus-related IPC messages at once.

The ::ParentActivated is much simpler without touching windows in other TabGroup and is the one shown up in the top unlabeled list.

I'd like to have this one labeled first.

Treeherder result looks good, btw:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7e2233694e43bd608d509cc565b932d01420d97
Attachment #8897341 - Attachment is obsolete: true
Attachment #8897401 - Flags: review?(wmccloskey)
Comment on attachment 8897401 [details] [diff] [review]
(v2) Patch: Label PContent::Msg_ParentActivated.

Review of attachment 8897401 [details] [diff] [review]:
-----------------------------------------------------------------

Can we just move this message from PContent to PBrowser?
Attachment #8897401 - Flags: review?(wmccloskey) → review-
Rollback the change of ParentActivated message done in bug 1334572 and bug 1347117.
Attachment #8897401 - Attachment is obsolete: true
Attachment #8900194 - Flags: review?(wmccloskey)
Comment on attachment 8900194 [details] [diff] [review]
(v2) Patch: Move ParentActivated message from PContent/PContentBridge back to PBrowser.

Review of attachment 8900194 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8900194 - Flags: review?(wmccloskey) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb2d85aa19a
Move ParentActivated message from PContent/PContentBridge back to PBrowser. r=billm
https://hg.mozilla.org/mozilla-central/rev/adb2d85aa19a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.