1390424 - Label PContent::Msg_ParentActivated

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

This IPC message contains PBrowser object.
We could reuse utilize this PBrowser to label this message with its corresponding TabGroup.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Label PContent::Msg_{Activate|Deactivate|ParentActivated}

Label these 3 IPC messages using the TabGroup of the PBrowserChild instance retrieved from the IPC messages.

Treeherder result looks fine so far:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=08ac306a0bd1b14be1226dc4e8868a648d865d29

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8897341 [details] [diff] [review]
(v1) Patch: Label PContent::Msg_{Activate|Deactivate|ParentActivated}

Review of attachment 8897341 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, we hit Assertion failure: IsSafeToRun() at RecvActivate()
GECKO(1095) | Assertion failure: IsSafeToRun(), at /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/SchedulerGroup.h:81
GECKO(1095) | #01: mozilla::dom::DocGroup::ValidateAccess [xpcom/threads/SchedulerGroup.h:81]
GECKO(1095) | #02: nsDocument::GetEventTargetParent [dom/base/nsDocument.cpp:8049]
GECKO(1095) | #03: mozilla::EventTargetChainItem::GetEventTargetParent [dom/events/EventDispatcher.cpp:211]
GECKO(1095) | #04: mozilla::EventDispatcher::Dispatch [dom/events/EventDispatcher.cpp:751]
GECKO(1095) | #05: FocusBlurEvent::Run [dom/base/nsFocusManager.cpp:2051]
GECKO(1095) | #06: nsContentUtils::AddScriptRunner [dom/base/nsContentUtils.cpp:5741]
GECKO(1095) | #07: nsContentUtils::AddScriptRunner [dom/base/nsContentUtils.cpp:5748]
GECKO(1095) | #08: nsFocusManager::FireFocusOrBlurEvent [dom/base/nsFocusManager.cpp:2235]
GECKO(1095) | #09: nsFocusManager::SendFocusOrBlurEvent [dom/base/nsFocusManager.cpp:2154]
GECKO(1095) | #10: nsFocusManager::Blur [dom/base/nsFocusManager.cpp:1784]
GECKO(1095) | #11: nsFocusManager::WindowLowered [dom/base/nsFocusManager.cpp:810]
GECKO(1095) | #12: nsFocusManager::WindowRaised [dom/base/nsFocusManager.cpp:706]
GECKO(1095) | #13: nsWebBrowser::Activate [toolkit/components/browser/nsWebBrowser.cpp:1826]
GECKO(1095) | #14: mozilla::dom::TabChild::RecvActivate [ipc/glue/ProtocolUtils.h:247]
GECKO(1095) | #15: mozilla::dom::ContentChild::RecvActivate [dom/ipc/ContentChild.cpp:3448]
GECKO(1095) | #16: mozilla::dom::PContentChild::OnMessageReceived [obj-firefox/ipc/ipdl/PContentChild.cpp:7882]

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v2) Patch: Label PContent::Msg_ParentActivated.

It's too greedy to label these 3 focus-related IPC messages at once.

The ::ParentActivated is much simpler without touching windows in other TabGroup and is the one shown up in the top unlabeled list.

I'd like to have this one labeled first.

Treeherder result looks good, btw:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7e2233694e43bd608d509cc565b932d01420d97

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8897401 [details] [diff] [review]
(v2) Patch: Label PContent::Msg_ParentActivated.

Review of attachment 8897401 [details] [diff] [review]:
-----------------------------------------------------------------

Can we just move this message from PContent to PBrowser?

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v2) Patch: Move ParentActivated message from PContent/PContentBridge back to PBrowser.

Rollback the change of ParentActivated message done in bug 1334572 and bug 1347117.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8900194 [details] [diff] [review]
(v2) Patch: Move ParentActivated message from PContent/PContentBridge back to PBrowser.

Review of attachment 8900194 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb2d85aa19a
Move ParentActivated message from PContent/PContentBridge back to PBrowser. r=billm

Comment 8

[Sebastian Hengst [:aryx] [limited availability until start of 2020] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/adb2d85aa19a