js strict warnings in filepicker.js

VERIFIED FIXED

Status

Core Graveyard
File Handling
--
trivial
VERIFIED FIXED
16 years ago
a year ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Warning: redeclaration of var errorTitle
Source File: chrome://global/content/filepicker.js
Line: 305, Column: 12
Source Code:
        var errorTitle =

Warning: redeclaration of var errorMessage
Source File: chrome://global/content/filepicker.js
Line: 308, Column: 12
Source Code:
        var errorMessage;

I'll attach a patch
Created attachment 80305 [details] [diff] [review]
patch

(the variables are defined at the top of the function)

Comment 2

16 years ago
Comment on attachment 80305 [details] [diff] [review]
patch

r=doron
Attachment #80305 - Flags: review+
alecf, can you super-review? thanks!

Comment 4

16 years ago
Comment on attachment 80305 [details] [diff] [review]
patch

sr=alecf
Attachment #80305 - Flags: superreview+
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
no longer see this warning --vrfy'd with 2002.09.19.08 comm trunk build.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.