139044 - js strict warnings in filepicker.js

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Warning: redeclaration of var errorTitle
Source File: chrome://global/content/filepicker.js
Line: 305, Column: 12
Source Code:
        var errorTitle =

Warning: redeclaration of var errorMessage
Source File: chrome://global/content/filepicker.js
Line: 308, Column: 12
Source Code:
        var errorMessage;

I'll attach a patch

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

(the variables are defined at the top of the function)

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 80305 [details] [diff] [review]
patch

r=doron

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

alecf, can you super-review? thanks!

Comment 4

[Alec Flett]

Comment on attachment 80305 [details] [diff] [review]
patch

sr=alecf

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 6

[sairuh (rarely reading bugmail)]

no longer see this warning --vrfy'd with 2002.09.19.08 comm trunk build.