1390459 - mulby3 function implement error on mips platform

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[yuyin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4

Steps to reproduce:

write a js file:

const testMap = new Map([["a","A"], ["b", "B"], ["c" , "C"]]);

function tM(ss) {
    for (var s of ss) {
       print(s);
   }
}


tM(testMap);


Actual results:

get wrong result:
a,A
b,B
0,-7.269300..


Expected results:

get right result:
a,A
b,B
c,C

Comment 1

[yuyin]

Sorry, it only get wrong result when run with --ion-eager --ion-offthread on mips platform.  but get right result when run without any parameter.

it is because mulby3 function implement error on mips platform.

Comment 2

[yuyin]

Attachment: MIPS-Fix-mulBy3.patch

Comment 3

[yuyin]

Attachment: MIPS-Fix-mulBy3.patch

sorry, please review this patch.

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8897373 [details] [diff] [review]
MIPS-Fix-mulBy3.patch

Review of attachment 8897373 [details] [diff] [review]:
-----------------------------------------------------------------

stealing review.

thank you for fixing :)
indeed src and dest are same and the code didn't work in that situation.

Comment 5

[yuyin]

yes, thank you.

(In reply to Tooru Fujisawa [:arai] from comment #4)
> Comment on attachment 8897373 [details] [diff] [review]
> MIPS-Fix-mulBy3.patch
> 
> Review of attachment 8897373 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> stealing review.
> 
> thank you for fixing :)
> indeed src and dest are same and the code didn't work in that situation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12ca48964380
mulby3 function implement error on mips platform. r=arai

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/12ca48964380