1390508 - history.forward() does not trigger hashchange

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Domenic Denicola]

Test: http://w3c-test.org/html/browsers/browsing-the-web/scroll-to-fragid/forward-triggers-hashchange.html

Edge and Chrome both pass. (Haven't tested Safari)

Comment 1

[Andrew Overholt [:overholt]]

Thanks. Gijs and smaug, I feel like we've discussed this before but maybe that wasn't in the context of the History API.

Comment 2

[:Gijs (he/him)]

(In reply to Andrew Overholt [:overholt] from comment #1)
> Thanks. Gijs and smaug, I feel like we've discussed this before but maybe
> that wasn't in the context of the History API.

I'm afraid I don't really recall... were you thinking of someone else? :-)

Assuming this also happens for history.back(), this looks like a dupe of bug 1052783. (Though maybe we want to keep them separate to track wpt things? I don't know.)

I won't have cycles to work on this before photon ships (and am probably not the right person anyway).

Comment 3

[Andrew Overholt [:overholt]]

(In reply to :Gijs from comment #2)
> (In reply to Andrew Overholt [:overholt] from comment #1)
> > Thanks. Gijs and smaug, I feel like we've discussed this before but maybe
> > that wasn't in the context of the History API.
> 
> I'm afraid I don't really recall... were you thinking of someone else? :-)

I think it was more general navigation things around the location bar and docshell and hashchanges. But Anne and I spoke about this earlier today and it's clear to me now that it's just a bigger set of issues.

> Assuming this also happens for history.back(), this looks like a dupe of bug
> 1052783. (Though maybe we want to keep them separate to track wpt things? I
> don't know.)

Let's keep them separate for now. Thanks for the reference to that bug!

Comment 4

[Domenic Denicola]

FWIW, I saw https://bugzilla.mozilla.org/show_bug.cgi?id=1052783 but thought that since document.write() was involved, it was potentially a different pathology. This test case doesn't involve document.write() but still triggers a similar issue.

(Might still be the same root cause, of course.)

Comment 5

[Peter Van der Beken [:peterv]]

Looks fixed to me.