1390521 - Set prefs to automate gUM-prompts for more (WebRTC) web-platform tests

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

+++ This bug was initially created as a clone of Bug #1376960 +++

Continue the good work of that bug for the webrtc WPT tests, e.g.

  testing/web-platform/tests/webrtc/RTCPeerConnection-addTrack.html
  etc.

Several of the webrtc tests also rely on getUserMedia. Some of them are timing out right now, or worse intermittently going orange (bug 1388550).

Comment 1

[Andreas Pehrson [:pehrsons]]

I have the prefs to enable gUM set but there's something wrong as WPT is not picking them up: [1]

There are two prefs set for all webrtc wpt tests. One for disabling the permission prompt, one for enabling fake devices. I can reproduce the results on linux - no fake devices enabled, so for me it uses the physical camera and microphone instead. That is likely why it is passing on other platforms than Mac on try.

On linux I have also reproduced this in rr, and it's clear that `Preferences::GetBool("media.navigator.streams.fake")` (from [2]) returns false.

James, do you know of any issues with prefs in WPT? Any gotchas we could have missed?
To repro, apply the patch in [3] and run `./mach wpt testing/web-platform/tests/webrtc/RTCPeerConnection-addTrack.html`.
Check whether the mediacapture doorhanger or your camera light gets enabled. They shouldn't.

FWIW Setting the same prefs in my regular Nightly gives me fake devices just fine.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b252923f87266e3b510641a9a0d9c66a1af9e802&selectedJob=126431426
[2] http://searchfox.org/mozilla-central/rev/18c16ebf818abb86805ce08a6e537e4cd826f044/dom/media/MediaManager.cpp#2452
[3] https://hg.mozilla.org/try/rev/8508c0dcf559f18f5ecef909443b04933573aa72

Comment 2

[Andreas Pehrson [:pehrsons]]

I can see in rr that the first pref in the list ("media.navigator.permission.disabled":true) gets set initially. The other one doesn't. Putting the fake streams first doesn't help.

Is this because the permission pref is in libpref/init/all.js but the fake streams one isn't? Is that a bug?

Comment 3

[Andreas Pehrson [:pehrsons]]

I can confirm that adding "media.navigator.streams.fake" to all.js makes it work. It would still be nice to support other prefs, since there are some that we don't want exposed to about:config.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1390521 - Use fake streams and disable the prompt for all WebRTC WPT tests.

Review commit: https://reviewboard.mozilla.org/r/173648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173648/

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1390521 - Enable tests.

Review commit: https://reviewboard.mozilla.org/r/173650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173650/

Comment 6

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1390521 - Expose pref "media.navigator.streams.fake" in all.js.

Review commit: https://reviewboard.mozilla.org/r/173652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173652/

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8902178 [details]
Bug 1390521 - Enable tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173650/diff/1-2/

Comment 8

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8902179 [details]
Bug 1390521 - Expose pref "media.navigator.streams.fake" in all.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173652/diff/1-2/

Comment 9

[James Graham [:jgraham]]

Seems like bug 1395119 is the underlying cause here, so clearing this needinfo.

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8902177 [details]
Bug 1390521 - Use fake streams and disable the prompt for all WebRTC WPT tests.

https://reviewboard.mozilla.org/r/173648/#review180078

Comment 11

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8902178 [details]
Bug 1390521 - Enable tests.

https://reviewboard.mozilla.org/r/173650/#review180086

lgtm

Comment 12

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8902179 [details]
Bug 1390521 - Expose pref "media.navigator.streams.fake" in all.js.

https://reviewboard.mozilla.org/r/173652/#review180088

I guess it doesn't hurt to show this one in about:config

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3195f3e50f
Use fake streams and disable the prompt for all WebRTC WPT tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/50b20d466c17
Enable tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/5456ea5ec717
Expose pref "media.navigator.streams.fake" in all.js. r=jib

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dc3195f3e50f
https://hg.mozilla.org/mozilla-central/rev/50b20d466c17
https://hg.mozilla.org/mozilla-central/rev/5456ea5ec717