Closed Bug 1390529 Opened 8 years ago Closed 7 years ago

Toolbar screenshot button doesn't work

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P3)

x86
Windows 10
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sole, Unassigned)

Details

* Expected: clicking screenshot button would generate a screenshot and place it on the downloads folder * actual results: nothing happens The trace: createScreenshotData@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/commands/screenshot.js:319:3 captureScreenshot@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/commands/screenshot.js:249:10 exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/commands/screenshot.js:215:14 Requisition.prototype.exec/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/source/lib/gcli/cli.js:2085:16 asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:235:18 spawn@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:160:12 exports.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/source/lib/gcli/util/host.js:63:10 Requisition.prototype.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/source/lib/gcli/cli.js:2084:14 Requisition.prototype.updateExec/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/source/lib/gcli/cli.js:2124:12 promise callback*Requisition.prototype.updateExec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/gcli/source/lib/gcli/cli.js:2123:10 promise callback*execute@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/gcli.js:88:12 handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:1081:19 onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/main.js:1797:15 receiveMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:761:7 Looking at the code there's a ctx.scale(ratio, ratio) at the top error location: devtools/shared/gcli/commands/screenshot.js:319:3 An initial guess is that maybe the ratio is a wrong value (undefined?) and the context scale is throwing. Ben says "maybe!" because he has a scaled monitor things are getting weird here. The ratio is assigned a few lines before with `const ratio = args.dpr ? args.dpr : window.devicePixelRatio;` - it might be interesting to look at what value is in ratio. I can't reproduce on a MacOS MacBook using built in monitor.
I'll try changing my win10 monitor scaling later today.
Flags: needinfo?(bkelly)
Priority: -- → P3
Product: Firefox → DevTools
Sorry, I never got around to this.
Flags: needinfo?(bkelly)
I have changed the scaling to various settings and I can take screenshots with the button in all cases, here using Windows with an external monitor both plugged in and with the built in monitor too. Closing because I can't reproduce--maybe the recent work on screenshots fixed this!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.