1390573 - Clean up stale pyc files during Vagrant provision

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Since otherwise if paths have changed in the meantime (eg if previously there was an attempt to run the tests outside the VM, when the host is Windows and doesn't use unix style paths), pytest fails with the rather unhelpful:

"""
vagrant ~/treeherder $ pytest tests/etl/test_buildbot.py
Traceback (most recent call last):
  File "/home/vagrant/python/lib/python2.7/site-packages/_pytest/config.py", line 379, in _importconftest
    mod = conftestpath.pyimport()
  File "/home/vagrant/python/lib/python2.7/site-packages/py/_path/local.py", line 680, in pyimport
    raise self.ImportMismatchError(modname, modfile, self)
ImportMismatchError: ('tests.conftest', 'c:\\Users\\elvis\\treeherder\\tests\\conftest.py', local('/home/vagrant/treeher
der/tests/conftest.py'))
ERROR: could not load /home/vagrant/treeherder/tests/conftest.py
"""

(As hit by Joel today: https://pastebin.mozilla.org/9029781)

These stale pyc files are easy to miss when debugging, since they are (/have to be) git ignored.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:vagrant-pyc-cleanup > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/729183f41f88f5c4070e0069e2f6ac3c2bfcadf4
Bug 1390573 - Vagrant: Move the cleanup step earlier in provision

To reduce the risk that one of the commands we run is broken by things
that need cleaning up (eg pyc files). An unnecessary `|| true` has also
been removed from the `rm -f` moved command.

https://github.com/mozilla/treeherder/commit/1fee79052b34049163c6d737386de6fb0efbdbac
Bug 1390573 - Vagrant: Remove .pyc files during provision

To prevent confusing pytest `ImportMismatchError` exceptions if the
paths hardcoded in pyc files (which are git-ignored) leftover from
the past, don't match the paths used now.