Closed Bug 1390658 Opened 2 years ago Closed 2 years ago

Tools -> Web Developer -> Get More Tools takes me to a page of tools I can't install.

Categories

(DevTools :: General, enhancement, P2)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Atoll, Assigned: trash, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

"Get More Tools" is somewhat useless right now, which is perhaps unsurprising due to 57. However, I'm not sure we're sending the right message by directing developers to a page of addons we then prohibit them from installing (and the first result is Firebug, which is EOL'd).

While in theory these addons might update to WebExtensions someday, in the meantime, it seems ill-advised for us to be sending developers to this page as it is today.

I encourage reconsidering including this menu item, or working with AMO to get a filtered result set.
Thanks for reporting this bug.

We should create a new collection (or just update the one being used currently), especially since there now are brand new extensions (using WebExtensions API) like for React or Vue.js, etc. see these ones: https://addons.mozilla.org/en-US/firefox/search/?q=devtools&platform=windows&tag=firefox57

Looks like a new collection was created with the React, Redux and Vue.js extensions: https://addons.mozilla.org/en-US/firefox/collections/mozilla/framework-devtools/

Andy: do you know who maintains these collections?

On the DevTools side, the URL is hard-coded here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/menus.js#149
Flags: needinfo?(amckay)
Bouncing over to Scott
Flags: needinfo?(amckay) → needinfo?(sdevaney)
Yes, lets use the new framework devtools collection URL.  That's what our https://www.mozilla.org/firefox/developer/ page points to as well.
Sounds good. I'd like to know how to update the content of this collection though. So that we can make sure it's always as up to date as we can make it, with all the newest DevTools extensions (not just framework ones too).

In any case, this is a very simple bug to fix if someone wants to attempt it.
As I said in comment 1, the code to change is in /devtools/client/menu.js, line 149 is the URL that needs to be changed.
To do this, you'll need to checkout the code, make the change, build Firefox, test, and then submit a change here for review by a DevTools peer. You can learn about how to do this here: http://docs.firefox-dev.tools/getting-started/
Mentor: pbrosset
Component: General → Developer Tools
Keywords: good-first-bug
Scott can update that collection.  I'd recommend keeping that one geared toward just the frameworks and if we wanted a new / different collection we create that as well.  We reference this collection for a specific purpose, I would keep it focused.
Yep, I create and maintain these. Absolutely feel free to send me content recommendations. 

1 September is the date we designated to remove all featured legacy content, which would include collections like these. But given this collection's unique irrelevance, I can pull it down now.
Flags: needinfo?(sdevaney)
Priority: -- → P2
I am a new person here looking to contribute to Mozilla. I would like to work on this bug. Can someone guide me which technologies are required for me to know to handle this bug.
I don't 100% understand the review process for mozilla, but I made a patch simple inserting Patrick Brosset's <:pbro> link into the line he mentioned. I then used `hg push review`. It ended up over here https://reviewboard.mozilla.org/r/173018/
Can someone work on a issue without being assigned?
Attachment #8901644 - Flags: review?(pbrosset)
(In reply to Pradeep Gangwar [:Pradeep] from comment #7)
> I am a new person here looking to contribute to Mozilla. I would like to
> work on this bug. Can someone guide me which technologies are required for
> me to know to handle this bug.
Thank you for your interest. I had already described this a little bit in comment 4. Please take a look. There's a link to the contribution documentation, and a reference to the javascript file that needed to be changed.

Unfortunately, looks like Christopher already supplied a patch for this bug. But the contribution doc will be useful to you for any other DevTools bug. Note that you can find other bugs to work on here: http://bugs.firefox-dev.tools/?easy&tool=all&mentored

(In reply to Christopher Phonis-Phine from comment #9)
> I don't 100% understand the review process for mozilla, but I made a patch
> simple inserting Patrick Brosset's <:pbro> link into the line he mentioned.
> I then used `hg push review`. It ended up over here
> https://reviewboard.mozilla.org/r/173018/
You got it right. You simply forgot to add a reviewer's name into the commit message like so:

Bug 1390658 - Change getMoreDevtools menuitem to new collection; r=pbro

Note the "; r=pbro"  at the end of the commit message first line. This is what requests a review from someone (me in that case).
But, yes, pushing to the reviewboard server is the right thing to do.

I'll take a look at your code changes now.

(In reply to Pradeep Gangwar [:Pradeep] from comment #10)
> Can someone work on a issue without being assigned?
Yes of course, patches are always welcome, although to avoid confusion as to who's working on a bug, it's always better to make sure people are assigned to bugs first. In practice, there aren't a lot of collisions usually. It happened here unfortunately, because no one had the opportunity to assign the bug to you when you said you were interested. Don't worry, there are many other bugs :)
Comment on attachment 8901644 [details]
Bug 1390658 - Change getMoreDevtools menuitem to new collection

https://reviewboard.mozilla.org/r/173018/#review178476

::: devtools/client/menus.js:149
(Diff revision 1)
>    },
>    { id: "getMoreDevtools",
>      l10nKey: "getMoreDevtoolsCmd",
>      oncommand(event) {
>        let window = event.target.ownerDocument.defaultView;
> -      window.openUILinkIn("https://addons.mozilla.org/firefox/collections/mozilla/webdeveloper/", "tab");
> +      window.openUILinkIn("https://addons.mozilla.org/en-US/firefox/collections/mozilla/framework-devtools/", "tab");

I just realized that we should not have the en-US part in this URL, this way the right language will be chosen for each user automatically.

So can you please ammend your commit and push again with this URL instead?

https://addons.mozilla.org/firefox/collections/mozilla/framework-devtools/
Attachment #8901644 - Flags: review?(pbrosset)
First off, sorry Pradeep Gangwar, I didn't see your comment!

Second, Patrick Brosset, how do I know who should be the reviewer? Was it you in this case because you were the mentor on this bug? (Hope this isn't too off-topic)

Third, good catch, thanks. I pushed a patch with that link instead. (And darn, I forgot to include you as reviewer on the new one because I copied the commit message from the only one. I hope that's ok.)
(In reply to Christopher Phonis-Phine from comment #14)
> Second, Patrick Brosset, how do I know who should be the reviewer? Was it
> you in this case because you were the mentor on this bug? (Hope this isn't
> too off-topic)
Yes, when a bug has a mentor defined, then asking reviews to this person is the right thing to do. When mentor add their names to bugs, that means they will help the bug assignee for anything they require to solve the bug. Even if they can't review the patch, they probably know someone who would.

In case there are no mentors, you can find the full list of DevTools peers here: https://wiki.mozilla.org/Modules/All#DevTools
A DevTools peer is someone who is able to do reviews on the code inside /devtools/
There are many peers, asking any of them is fine. If they end up not being the right person (because DevTools is big and peers don't all know the whole code), they know who can review the change.

Another way is to look at file change history in Mercurial.
Personally, I have a "hg who" alias configured like this:

[alias]
who = !hg anno -u $1 | awk '{print $$1}' | sort | uniq -c | sort -r

I can then type "hg who devtools/client/menus.js" to know who made most of the changes on this file.
Assignee: nobody → judahiii
Status: NEW → ASSIGNED
Comment on attachment 8901644 [details]
Bug 1390658 - Change getMoreDevtools menuitem to new collection

https://reviewboard.mozilla.org/r/173018/#review178928
Attachment #8901644 - Flags: review?(pbrosset) → review+
Thanks for the new commit. Looks good.
I've added R+ to it, so it's good to land as soon as we make sure tests still pass (which, I'm sure they will, this is only a URL change). So I pushed to our CI server (TRY). You can follow the build and test results progress here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=50fe8ab89be83fee5cd2066b99fb7dcc6d1a4b1e
Just requested a push of this commit to autoland. This means your fix will be making its way to the mozilla-central repository soon (which in turn means your fix will be in a Firefox nightly build very soon!)
Thanks!
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/939ca50ab15d
Change getMoreDevtools menuitem to new collection r=pbro
https://hg.mozilla.org/mozilla-central/rev/939ca50ab15d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug with Nightly 57.0a1 (2017-08-15) on Windows 8.1, 64 Bit!

This bug's fix is verified on Latest Nightly 57.0a1

Build ID : 20170830100230
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170830]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.