Closed Bug 1390687 Opened 5 years ago Closed 5 years ago

Remove script version from script in test

Categories

(Core :: DOM: Security, enhancement, P2)

56 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kmckinley, Assigned: kmckinley)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Remove javascript version from test and replace legacy generators. (See bug 1342144)
Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

https://reviewboard.mozilla.org/r/168888/#review174430

::: commit-message-6213f:1
(Diff revision 1)
> +Bug 1390687 - remove versioned javascript and legacy generator code r?emk

Ah, I already fixed this file in bug 1390106. Sorry for wasting your time.
Attachment #8897627 - Flags: review?(VYV03354)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1390106
Oops, I didn't remove the version parameter in bug 1390106.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

https://reviewboard.mozilla.org/r/168888/#review174434

::: dom/security/test/cors/browser_CORS-console-warnings.js:35
(Diff revision 1)
>  function do_cleanup() {
>    if (webconsole) {
>      webconsole.ui.off("new-messages", on_new_message);
>    }
> -  yield unsetCookiePref();
> +
> +  unsetCookiePref().then({});

I fixed this in bug 1390106 by changing this function to a modern generator (function*) instead of using .then().

Please drop this change.

::: dom/security/test/cors/browser_CORS-console-warnings.js:69
(Diff revision 1)
>    //jscs:enable
>    // A longer timeout is necessary for this test than the plain mochitests
>    // due to opening a new tab with the web console.
>    requestLongerTimeout(4);
>    registerCleanupFunction(do_cleanup);
> -  yield setCookiePref();
> +  setCookiePref().then({});

You don't have to change this because this yield is already enclosed by a star function.

::: dom/security/test/cors/file_cors_logging_test.html:27
(Diff revision 1)
>  function initTest() {
>    window.addEventListener("message", function(e) {
>      gen.next(e.data);
>    });
>  
> -  gen = runTest();
> +  gen = nextStep();

Why did you change the function name?
Attachment #8897627 - Flags: review?(VYV03354)
Priority: -- → P2
Whiteboard: [domsecurity-active]
Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

https://reviewboard.mozilla.org/r/168888/#review174678
Attachment #8897627 - Flags: review?(VYV03354) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/2d9e88c879dc
remove versioned javascript and legacy generator code r=emk
https://hg.mozilla.org/mozilla-central/rev/2d9e88c879dc
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.