1390687 - Remove script version from script in test

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Kate McKinley [:kmckinley, :Kate]]

Remove javascript version from test and replace legacy generators. (See bug 1342144)

Comment 1

[Kate McKinley [:kmckinley, :Kate]]

Attachment: Bug 1390687 - remove versioned javascript and legacy generator code

Review commit: https://reviewboard.mozilla.org/r/168888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168888/

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

https://reviewboard.mozilla.org/r/168888/#review174430

::: commit-message-6213f:1
(Diff revision 1)
> +Bug 1390687 - remove versioned javascript and legacy generator code r?emk

Ah, I already fixed this file in bug 1390106. Sorry for wasting your time.

Comment 4

[Masatoshi Kimura [:emk]]

Oops, I didn't remove the version parameter in bug 1390106.

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

https://reviewboard.mozilla.org/r/168888/#review174434

::: dom/security/test/cors/browser_CORS-console-warnings.js:35
(Diff revision 1)
>  function do_cleanup() {
>    if (webconsole) {
>      webconsole.ui.off("new-messages", on_new_message);
>    }
> -  yield unsetCookiePref();
> +
> +  unsetCookiePref().then({});

I fixed this in bug 1390106 by changing this function to a modern generator (function*) instead of using .then().

Please drop this change.

::: dom/security/test/cors/browser_CORS-console-warnings.js:69
(Diff revision 1)
>    //jscs:enable
>    // A longer timeout is necessary for this test than the plain mochitests
>    // due to opening a new tab with the web console.
>    requestLongerTimeout(4);
>    registerCleanupFunction(do_cleanup);
> -  yield setCookiePref();
> +  setCookiePref().then({});

You don't have to change this because this yield is already enclosed by a star function.

::: dom/security/test/cors/file_cors_logging_test.html:27
(Diff revision 1)
>  function initTest() {
>    window.addEventListener("message", function(e) {
>      gen.next(e.data);
>    });
>  
> -  gen = runTest();
> +  gen = nextStep();

Why did you change the function name?

Comment 6

[Kate McKinley [:kmckinley, :Kate]]

Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168888/diff/1-2/

Comment 7

[Masatoshi Kimura [:emk]]

Comment on attachment 8897627 [details]
Bug 1390687 - remove versioned javascript and legacy generator code

https://reviewboard.mozilla.org/r/168888/#review174678

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d9e88c879dc
remove versioned javascript and legacy generator code r=emk

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2d9e88c879dc