Closed
Bug 1390699
Opened 7 years ago
Closed 7 years ago
python/mozlint/test/test_cli.py fails on windows buildbots
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 57.0
People
(Reporter: tomprince, Assigned: tomprince)
References
Details
Attachments
(2 files)
python/mozlint/test/test_cli.py::test_cli_run_with_edit fails on windows buildbots in thunderbird because "echo" isn't installed there.
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c19ddfe3ccc9250de187a650ddf83f4991fa3d42 https://treeherder.mozilla.org/#/jobs?repo=try&revision=9be1144ea447f4789b2e02bd3b5b93c7c0bfc9de
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mozilla
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897646 [details] Bug 1390699 - Use same logic as `subprocess.Popen` to find echo. https://reviewboard.mozilla.org/r/168908/#review174518
Attachment #8897646 -
Flags: review?(ahalberstadt) → review+
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/761d106f33d5 Don't try to test mozlint's --edit if `echo` isn't available; r=ahal
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/761d106f33d5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
|
|
Assignee | |
Comment 7•7 years ago
|
||
It turns out that `py.path.local.sysfind` uses logic that is different that what `CreateProcess` does for find executables.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 10•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4d2c8ff9570860e253d615c80e6579fe8dc60deb&selectedJob=123788959 https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bebc8939fbeb786170b3b71461494b83b2eccd5&selectedJob=123788486
|
||
Comment 11•7 years ago
|
||
Aryx, can you please get this landed on M-C. (Where is :Tomcat?)
Flags: needinfo?(aryx.bugmail)
|
|
||
Comment 12•7 years ago
|
||
Sorry, I got confused. The patch already landed and the second one doesn't have review yet.
Flags: needinfo?(aryx.bugmail)
|
|
||
Comment 13•7 years ago
|
||
Looks like Tom is not available at the moment, but we need to move this forward.
Attachment #8900597 -
Flags: review?(ahalberstadt)
|
|
||
Updated•7 years ago
|
Attachment #8900597 -
Flags: review?(ahalberstadt) → review+
|
|
||
Comment 14•7 years ago
|
||
Andrew, would you be able to push that for me or should I ask a sheriff? They usually don't see the "checkin needed" since it's in product Thunderbird. Thanks for the quick review. I'm just the guy picking up the pieces here.
Flags: needinfo?(ahalberstadt)
|
||
Comment 16•7 years ago
|
||
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07e49c7dfd58 Follow-up: Use find_executable() to locate echo. r=ahal
|
||
Comment 17•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/07e49c7dfd58
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•