1390707 - Add `extensions.legacy.enabled` pref to Telemetry Aggregates

Status: RESOLVED FIXED

(Data Platform and Tools :: General, enhancement, P2)

Description

[Ben Miroglio [:bmiroglio]]

*This is for Nightly 57 ONLY*

Having this pref in TMO would help the add-ons team 

1.) track blowback on Nightly since we just set extensions.legacy.enabled = false by default. 
2.) filter out Users on Nightly 57 that reset the pref back to true

The alternative is generating custom reports, however if adding the pref to TMO is trivial then let's do that :). 

Frank--what's your take on this?

Comment 1

[Frank Bertsch [:frank]]

We've decided that this is too specific of an ask for the aggregator. Instead we should add this information to main_summary, where we can easily query it in re:dash and build reports there.

The schema needs updated: https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/views/MainSummaryView.scala#L799

As well as the function to retrieve the prefs: https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/views/MainSummaryView.scala#L307

And then it will show. Does this work for you, Ben?

Comment 2

[Ben Miroglio [:bmiroglio]]

Yes, that works for me. Thanks :)

Comment 3

[Mark Reid [:mreid]]

Frank, do you have time to work on this?

Comment 4

[Frank Bertsch [:frank]]

Not immediately, I'm bogged down with experiments + heavy_users stuff.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/telemetry-batch-view/pull/323

Comment 6

[Mark Reid [:mreid]]

User prefs are stored as a nested struct in main_summary.

Unfortunately, adding new fields to a nested struct causes schema evolution to fail (and hence will break the dataset in re:dash).

The above PR will need to be re-worked to use a different approach - I suggest we flatten all the prefs into top-level fields named "user_pref_<sanitized pref name>"

Frank, what do you think of this approach (it's similar to what we do for scalars and histograms currently)?

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/telemetry-batch-view/pull/338

Comment 8

[Frank Bertsch [:frank]]

Good plan, happy to see you kept the old prefs as they were. I'm reviewing now.

Comment 9

[Mark Reid [:mreid]]

This has been added - a new top-level field called "user_pref_extensions_legacy_enabled" will appear in tomorrow's table.