Closed Bug 1390721 Opened 2 years ago Closed 2 years ago

Add a message when no fonts are found for the currently selected element

Categories

(DevTools :: Inspector: Fonts, enhancement, P3)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Depends on: 1390727
Attached patch 1390721.patch (obsolete) — Splinter Review
Attachment #8897694 - Flags: review?(bgrinstead)
Comment on attachment 8897694 [details] [diff] [review]
1390721.patch

Review of attachment 8897694 [details] [diff] [review]:
-----------------------------------------------------------------

This breaks the 'show all fonts' button on doctypes
Attachment #8897694 - Flags: review?(bgrinstead) → review-
Comment on attachment 8898488 [details] [diff] [review]
1390721.patch [1.0]

Review of attachment 8898488 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/inspector/fonts/fonts.js
@@ +142,3 @@
>  
> +    // Clear the list of fonts if the currently selected node is not connected or an
> +    // element node unless all fonts are suppose to be shown.

Nit: supposed
Attachment #8898488 - Flags: review?(bgrinstead) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34d11e7339f3
Add a message when no fonts are found for the currently selected element. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/34d11e7339f3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.