Closed
Bug 1390730
Opened 7 years ago
Closed 7 years ago
Various SM async tests are going to permafail when Gecko 57 merges to Beta on 2017-09-20
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla57
People
(Reporter: RyanVM, Assigned: arai)
References
Details
Attachments
(1 file)
|
7.40 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Various JS test failures on the next merge day. Looks like this is the inverse of bug 1386026 now that bug 1352312 has landed. I guess we just need to remove the nightly-only.js guards from the affected tests now. https://treeherder.mozilla.org/logviewer.html#?job_id=123425979&repo=try
Flags: needinfo?(arai.unmht)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•7 years ago
|
||
removed nightlyOnly call from bug 1386026. nightly-only.js is kept for future use, but might be better removing at the same time?
Flags: needinfo?(arai.unmht)
Attachment #8897734 -
Flags: review?(jimb)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8897734 [details] [diff] [review] Remove nightly-only guard from tests for async iteration. Review of attachment 8897734 [details] [diff] [review]: ----------------------------------------------------------------- I'm so delighted that this worked out as planned. Let's leave nightly-only for now. I worry that people will not use it because they don't know it's there, but we can hope.
Attachment #8897734 -
Flags: review?(jimb) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6e3d03efcdd8 Remove nightly-only guard from tests for async iteration. r=jimb
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e3d03efcdd8e41d62ff9d7e5240987b85862d1d Bug 1390730 - Remove nightly-only guard from tests for async iteration. r=jimb
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6e3d03efcdd8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
Reporter | |
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
This is fixed, no need to track it.
You need to log in
before you can comment on or make changes to this bug.
Description
•