1390737 - test_canMakePayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20

Status: VERIFIED FIXED

(Core :: DOM: Web Payments, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing tests on the next merge day.

Do we need to just make this test run on Nightly only as well?

https://treeherder.mozilla.org/logviewer.html#?job_id=123432829&repo=try

TEST-UNEXPECTED-TIMEOUT | dom/payments/test/test_canMakePayment.html | application timed out after 330 seconds with no output

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390737 - Run nightly UI dependent testcase test_canMakePayment.html in nightly only. r?btain

Running the test_canMakePayment.html in nightly_build only, because the test depends on the nightly only UI service.

Because Baku is on PTO, I request Ben, who is also working on PaymentRequest, to help to review the patch.

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8897703 [details] [diff] [review]
Bug 1390737 - Run nightly UI dependent testcase test_canMakePayment.html in nightly only. r?btain

Review of attachment 8897703 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Eden Chuang[:edenchuang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19616ab74dfe9512ec92f8820c65e64065286a1d

Comment 4

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390737 - Run nightly UI dependent testcase test_canMakePayment.html in nightly only. r?btain

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f24528d4469
Run test_canMakePayment.html in nightly build only because it depends on nightly only UI service. r=btian

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f24528d4469

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is fixed, no need to track it.