Closed Bug 1390767 Opened 4 years ago Closed 4 years ago

UITour shouldn't put rounded-corner highlight on targets in the page action panel

Categories

(Firefox :: Tours, defect, P1)

Product:
Firefox
Component:
Tours
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- verified

People

(Reporter: Fischer, Assigned: Fischer)

References

Details

(Whiteboard: [photon-onboarding])

Attachments

(4 files)

non_rounded_corner_highlight_appMenu.png
37.80 KB, image/png
Details
rounded_corner_highlight_pageActionPanel.png
24.91 KB, image/png
Details
Bug 1390767 - UITour shouldn't put rounded-corner highlight on targets in the page action panel,
59 bytes, text/x-review-board-request
Gijs
: review+
Details
non_rounded_corner_highlight_pageActionPanel.png
16.17 KB, image/png
Details 
No description provided.
Assignee: nobody → fliu
Flags: qe-verify+
Priority: -- → P1
QA Contact: jwilliams
Whiteboard: [photon-onboarding]
UITour put non-rounded-corner highlight on targets in the app menu. See attachment 8897755 [details]: non_rounded_corner_highlight_appMenu.png
But put rounded-corner highlight on targets in the page action panel. See attachment 8897756 [details]: rounded_corner_highlight_pageActionPanel.png
UITour should put rounded-corner highlight on targets in the page action panel as well
(In reply to Fischer [:Fischer] from comment #4)
> Created attachment 8897757 [details]
> Bug 1390767 - UITour should put rounded-corner highlight on targets in the
> page action panel,
> 
> Review commit: https://reviewboard.mozilla.org/r/169062/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/169062/
Hi Gijs,
Please see the non-rounded-corner highlight on the page action panel, thanks.
attachment 8897759 [details]: non_rounded_corner_highlight_pageActionPanel.png
Target Milestone: --- → Firefox 57
Summary: UITour should put rounded-corner highlight on targets in the page action panel → UITour shouldn't put rounded-corner highlight on targets in the page action panel
Correct myself
(In reply to Fischer [:Fischer] from comment #3)
> UITour put non-rounded-corner highlight on targets in the app menu. See attachment 8897755 [details]: non_rounded_corner_highlight_appMenu.png
> But put rounded-corner highlight on targets in the page action panel. See attachment 8897756 [details]: rounded_corner_highlight_pageActionPanel.png
  UITour should put non-rounded-corner highlight on targets in the page action panel as well
Comment on attachment 8897757 [details]
Bug 1390767 - UITour shouldn't put rounded-corner highlight on targets in the page action panel,

https://reviewboard.mozilla.org/r/169062/#review174394
Attachment #8897757 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/23a7aa3e23c5
UITour shouldn't put rounded-corner highlight on targets in the page action panel, r=Gijs
Keywords: checkin-needed
Hi Justin,
We could verify this bug in the bug 1371538. The bug 1371538 will add a Screenshots tour that highlights the screenshots button in the page action panel. We could checkout out the highlight style on that button.
Flags: needinfo?(jwilliams)
https://hg.mozilla.org/mozilla-central/rev/23a7aa3e23c5
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
I have verified that this is fixed in today's nightly. I no longer see rounded-corner highlights.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jwilliams)
I can confirm this issue is fixed on beta as well. I verified using Fx 57.0b7 on Windows 10 x64, Ubuntu 14.04 LTS and macOS X 10.12.6.
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.