Closed Bug 1390771 Opened 7 years ago Closed 7 years ago

JavaScript error onBeginUpdateBatch

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- verified

People

(Reporter: bugzilla, Assigned: standard8)

References

Details

if I go to:
about:support

and click "Verify Integrity" under "Places Database"

JavaScript component does not have a method named: "onBeginUpdateBatch"'JavaScript component does not have a method named: "onBeginUpdateBatch"' when calling method: [nsINavHistoryObserver::onBeginUpdateBatch]
I believe this is coming from Activity Stream - if I disable Activity Stream and run Verify Integrity then the message goes away.

Looking at http://searchfox.org/mozilla-central/rev/b258e6864ee3e809d40982bc5d0d5aff66a20780/browser/extensions/activity-stream/lib/PlacesFeed.jsm#148 the other functions for the observer aren't defined - we do define them in other places, e.g.

http://searchfox.org/mozilla-central/rev/b258e6864ee3e809d40982bc5d0d5aff66a20780/services/sync/modules/engines/history.js#344
Component: Places → Activity Streams: Newtab
Product: Toolkit → Firefox
Assignee: nobody → standard8
Fixed by https://github.com/mozilla/activity-stream/pull/3318 to be uplifted via bug 1395642.
Blocks: 1395642
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-firefox57: --- → fixed
Target Milestone: --- → Firefox 57
Blocks: 1394533
The JavaScript error no longer appears when clicking "Verify Integrity" from about:support.
Verified as fixed using latest Nightly 57.0a1 Build ID 20170915100121, on Windows 10 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.