Closed Bug 1390776 Opened 7 years ago Closed 7 years ago

[gcc6] TEST-UNEXPECTED-FAIL | valgrind-test | 62 bytes in 1 blocks are definitely lost at malloc / PL_strdup / InstallSignalHandlers / SetupErrorHandling [log…]

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

INFO -   6:50.61 TEST-UNEXPECTED-FAIL | valgrind-test | 62 bytes in 1 blocks are definitely lost at malloc / PL_strdup / InstallSignalHandlers / SetupErrorHandling
[task 2017-08-16T05:25:01.924794Z] 05:25:01     INFO -   6:50.61 ==34615== 62 bytes in 1 blocks are definitely lost in loss record 4,143 of 7,858
[task 2017-08-16T05:25:01.925074Z] 05:25:01     INFO -   6:50.61 ==34615==    at 0x4C291BA: malloc (vg_replace_malloc.c:298)
[task 2017-08-16T05:25:01.925320Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x688110F: PL_strdup (strdup.c:21)
[task 2017-08-16T05:25:01.925546Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x10A07949: InstallSignalHandlers(char const*) (nsSigHandlers.cpp:231)
[task 2017-08-16T05:25:01.925717Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x109FCD66: SetupErrorHandling (nsAppRunner.cpp:5317)
[task 2017-08-16T05:25:01.925931Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x109FCD66: XREMain::XRE_mainInit(bool*) (nsAppRunner.cpp:3221)
[task 2017-08-16T05:25:01.926100Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x10A01CE1: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) (nsAppRunner.cpp:4790)
[task 2017-08-16T05:25:01.926253Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x10A02487: XRE_main(int, char**, mozilla::BootstrapConfig const&) (nsAppRunner.cpp:4905)
[task 2017-08-16T05:25:01.926408Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x406118: do_main(int, char**, char**) (nsBrowserApp.cpp:236)
[task 2017-08-16T05:25:01.926539Z] 05:25:01     INFO -   6:50.61 ==34615==    by 0x40581F: main (nsBrowserApp.cpp:309)

The amazing thing is that there is no way this leak doesn't already exist, so the question would be why are we not detecting it already?
Comment on attachment 8897771 [details]
Bug 1390776 - Put definition and uses of gProgname under #ifdef CRAWL_STACK_ON_SIGSEGV.

Turns out GCC6 is optimizing InstallSignalHandlers in a way that makes the leak relevant to valgrind when it wasn't before.
Attachment #8897771 - Flags: review?(n.nethercote)
Comment on attachment 8897771 [details]
Bug 1390776 - Put definition and uses of gProgname under #ifdef CRAWL_STACK_ON_SIGSEGV.

https://reviewboard.mozilla.org/r/169076/#review174420
Attachment #8897771 - Flags: review?(n.nethercote) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/112a2a2a66b7
Put definition and uses of gProgname under #ifdef CRAWL_STACK_ON_SIGSEGV. r=njn
https://hg.mozilla.org/mozilla-central/rev/112a2a2a66b7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: