If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Convert dom/html/test/test_fullscreen-api.html to comply with new data: URI inheritance model

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM: Security
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: ckerschb, Assigned: hchang)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [domsecurity-active])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

a month ago
Blocks: 1337269
Whiteboard: [domsecurity-active]
(Reporter)

Comment 1

a month ago
It seems that test is not loading any data: URIs but it's still failing on Windows:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37554efc3fb036d426fed8b8aca58148fcb8a4da&selectedJob=123487896
Assignee: nobody → hchang
(Reporter)

Comment 2

a month ago
Henry, I was able to reproduce the problem on MacOSX. The root of the problem is here [1]. One potential solution would be to rewrite the test to use a postMessagehandler. But totally up to you. Thanks for looking into this.

If you can't repro, let me know and I'll have a look at this one.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/html/test/file_fullscreen-api.html#40
Flags: needinfo?(hchang)
(Reporter)

Comment 3

a month ago
It seems that particular subtest is disabled on Linux, hence I wasn't able to reproduce at first.
Comment hidden (mozreview-request)
(Assignee)

Comment 5

a month ago
I have also spotted that use of data:uri (as well as another one in file_fullscreen-plugins.html)
and changed to srcdoc with a try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e3e7eb862714ec50129aef1326d75b52fe435e9

They look all good so the only thing of concern to you is the use of 'srcdoc'.
Do you think if we should avoid using srcdoc as you mentioned in [1]?

https://bugzilla.mozilla.org/show_bug.cgi?id=1324406#c21

Thanks :)
Flags: needinfo?(hchang)
Flags: needinfo?(ckerschb)
(Reporter)

Comment 6

a month ago
(In reply to Henry Chang [:hchang] from comment #5)
> They look all good so the only thing of concern to you is the use of
> 'srcdoc'.
> Do you think if we should avoid using srcdoc as you mentioned in [1]?

If srcdoc works we can obviously use srcdoc, happy to r+ that change if you flag me for review :-)
Flags: needinfo?(ckerschb) → needinfo?(hchang)
(Assignee)

Comment 7

a month ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e3e7eb862714ec50129aef1326d75b52fe435e9

I triggered more tries and there are still 2 failures out of 60 runs. (on Windows 7 opt)
However, I wonder if those failures are relevant to test_fullscreen-api-race.html
since they always fail altogether. So, I tend to land this fix first once I make sure
this is a permanent failure. (Argument: if "data: to srcdoc" is the issue, I would expect
this should always fail and a cross-origin check in requestFullScreen implementation.)

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=37554efc3fb036d426fed8b8aca58148fcb8a4da
Flags: needinfo?(hchang)
Comment hidden (mozreview-request)
(Assignee)

Updated

a month ago
Attachment #8897796 - Flags: review?(ckerschb)
(Reporter)

Comment 9

a month ago
mozreview-review
Comment on attachment 8897796 [details]
Bug 1390777 - Use srcdoc to replace src=data:xxx whenever possible.

https://reviewboard.mozilla.org/r/169090/#review174798

Those other failures on TRY definitely look like intermittents not related to the change here. r=ckerschb, thanks for fixing
Attachment #8897796 - Flags: review?(ckerschb) → review+

Comment 10

a month ago
Pushed by hchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11d08f128b4f
Use srcdoc to replace src=data:xxx whenever possible. r=ckerschb

Comment 11

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11d08f128b4f
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.