Closed
Bug 1390791
Opened 7 years ago
Closed 7 years ago
(photon) Adjust text size in tab counter dynamically
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, enhancement)
Firefox for Android Graveyard
Theme and Visual Design
Unspecified
Android
Tracking
(firefox57 verified)
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: jwu, Assigned: jwu)
References
Details
(Whiteboard: [FNC][SPT57.2][INT])
Attachments
(2 files)
The attachment shows that the text in tab counter overlaps the border when 1. Increase Font Size to 'Largest' in Settings, and 2. Tab count has two digits After discussing with designer, we would like to adjust the text size at runtime: 1. When there is one digit, the text size = width of tab counter * 0.7; 2. When there are two digits, the text size = width of tab counter * 0.5
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8897797 [details] Bug 1390791 - Adjust text size in tab counter dynamically. https://reviewboard.mozilla.org/r/169094/#review174754
Attachment #8897797 -
Flags: review?(cnevinchen) → review+
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8897797 [details] Bug 1390791 - Adjust text size in tab counter dynamically. https://reviewboard.mozilla.org/r/169094/#review175166 ::: mobile/android/app/src/photon/java/org/mozilla/gecko/toolbar/TabCounter.java:201 (Diff revision 1) > + * Adjust {@link #text} TextSize only when: > + * 1. First time initialization; > + * 2. Tab count changes from one digit to two digits; > + * 3. Tab count changes from two digits to one digit. > + */ > + private void adjustTextSize(int newCount) { current implementation is OK to me. Also we can also make some improvement such as ``` final float oldRatio = (this.count < MAX_TABS && this.count >= 10) ? TWO : ONE; final float newRatio = (newCount < MAX_TABS && newCount >= 10) ? TWO : ONE; ``` then compare to see if there is any change.
Attachment #8897797 -
Flags: review?(walkingice0204) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/22f4b610571c Adjust text size in tab counter dynamically. r=nechen,walkingice
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22f4b610571c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 7•7 years ago
|
||
Verified as fixed on Nightly 57 (2017-08-24). Devices: Xiaomi Mi Pad 2 (Android 5.1) HTC Nexus 9 (Android 7.1.1) Oneplus Two (Android 6.0.1) Prestigio Grace X5 (Android 4.4.2)
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Whiteboard: [FNC][SPT57.2][INT]
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•