13908 - Can't use cmd-m until I click in the bookmarks menu for the first time

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Mike Pinkerton (not reading bugmail)]

Open the browser window and click in it to set focus.
hit cmd-shift-m. Nothing happens.
Click the bookmarks menu, but don't pick anything.
hit cmd-shift-m again. Now the cmd-key equivalent works.

Comment 1

[saari (gone)]

If I remove the observer/broadcaster from this equation by just putting
onkeypress on the key node, this works correctly. Same thing with oncommand.

So, something strage is happening with the observer/broadcaster... both with the
menu needing to be pulled down, and with the shift key needing to be pressed.
Both of these problems only manifest with broadcasters/observers in the mix.

Comment 2

[Simon Fraser [no longer active]]

Didn't I file this same bug a while back? Bug 13378 is the one I'm thinking of.

Comment 3

[saari (gone)]

13378 looks similar, but was really a different issue.

There is something even more interesting happening here

Comment 4

[saari (gone)]

Assigning to waterson and marking M10 as it prevents keybinding from functioning
properly

Comment 5

[Chris Waterson]

okay, i fixed the "forward declaration of observers" problem; however, i'm
still seeing the problem that bug originally reported. Namely, I can't seem to
run "Ctrl+B" until the bookmarks menu has been created once. At least this
seems to be XP now: it's happening on Win32.

Comment 6

[Chris Waterson]

changed landed in trunk and M10 branch.

Comment 7

[Claudius Gayle]

I looked at 19990930 builds on all platforms and 'Ctrl-B' or command-b on
the mac all work without first creating the Bookmarks menu. marking VERIFIED.