139082 - nsCookieHttpNotify::OnExamineResponse was caused to frequently

Status: VERIFIED WONTFIX

(Core :: Networking: HTTP, defect)

Description

[jack.jia]

Because calling "nsHttpHandler::get()->OnExamineResponse(this)"( in 
nsHttpChannel::ProcessResponse()) will switch threads. I checked all the source 
code, the nsCookieHttpNotify and nsP3pHttpNotify is the only two reponse. so, I 
think we should add the decision condition in the nsHttpChannel::ProcessResponse
() only to call OnExamineReponse when the header is "set_cookie" & "P3P" .

In this way, we can reduce the times for switch threads. so, we can enhance the 
performance of browser.

Comment 1

[Matthias Versen [:Matti]]

-> Darin

Comment 2

[Darin Fisher]

i don't understand... what do you mean by switch threads?  necko is not
threadsafe.  you can only call HTTP from the main UI thread.  if you are doing
otherwise, you have bigger problems to worry about!!

Comment 3

[jack.jia]

    when I debug the mozilla. I set a breakpoint in the
nsCookieHttpNotify::OnExamineResponse, the program stop at breakpoints many
times, but most of them only decide if it was "set_cookie" and exit, only the
"set_cookie"
Http Response head process some valuable code.

    so, I think if we can add some decision condition in the high level (for
example in the nsHttpChannel::ProcessResponse()) , we can avoid the unuseful
call for  nsCookieHttpNotify::OnExamineResponse.

    "switch threads", because the subfunction for parsing httphead and
nsCookieHttpNotify::OnExamineResponse run in the diffrent threads. so , when i
debug, i see the switch thread. it is not my man idea. I file this bug in order
to reduce the times of calling nsCookieHttpNotify::OnExamineResponse.

Comment 4

[Darin Fisher]

ok... the problem you are describing is a well known problem.  the solution is
not to limit when we call OnExamineResponse.  that cannot be done because we
cannot know for sure that new consumers won't come along later... other xpcom
components can be written to implement OnExamineResponse.  this could be done
with a build that mozilla has already shipped, so there is no way to special
case OnExamineResponse.

see related bug 103745 and bug 96178 where this issue is discussed further.

marking WONTFIX

Comment 5

[benc]

V/wontfix, per darin.