1390834 - Report Site Issues in Page Action menu needs an ellipsis

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, defect)

Description

[Stephen Horlander [:shorlander]]

Because the "Report Site Issue" button requires further input and takes you to a new page it should have an ellipsis at the end: Report Site Issue…

Comment 1

[Mike Taylor [:miketaylr]]

Cool, will do.

Comment 2

[Mike Taylor [:miketaylr]]

Attachment: Bug 1390834. Add ellipsis to Report Site Issue page action button.

Review commit: https://reviewboard.mozilla.org/r/169278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169278/

Comment 3

[:Gijs (he/him)]

I think this will need a new entity, but I could be wrong. :flod will know for sure.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review176818

::: browser/extensions/webcompat-reporter/locales/en-US/webcompat.properties:8
(Diff revision 1)
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  # LOCALIZATION NOTE(wc-reporter.label): This string will be used in the
> -# Firefox menu panel below its button. Localized length should be considered.
> +# Firefox page actions menu. Localized length should be considered.
>  # \u00ad is included at the beginning of the string to disable auto-hyphens.
> -wc-reporter.label=\u00adReport Site Issue
> +wc-reporter.label=\u00adReport Site Issue…

You definitely need a new string ID for the added ellipsis, but since this is not the hamburger menu, you also don't need the \u00ad hack at the beginning.

Comment 5

[Mike Taylor [:miketaylr]]

Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169278/diff/1-2/

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review177762

You also need to update the code calling that string
http://searchfox.org/mozilla-central/rev/5696c3e525fc8222674eed6a562f5fcbe804c4c7/browser/extensions/webcompat-reporter/content/WebCompatReporter.jsm#31

Comment 7

[Mike Taylor [:miketaylr]]

Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review177762

That's.... embarassing. Apologies. (No more airport commits for me. >_<)

Comment 8

[Mike Taylor [:miketaylr]]

Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169278/diff/2-3/

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review179380

Been there, done that when trying to rush things :-)

Comment 10

[Mike Taylor [:miketaylr]]

Thanks for review!

I'm gonna push w/o a try build since it's just a string change (and the wecompat-reporter tests are passing locally after building with this patch).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cb237283ed0
Add ellipsis to Report Site Issue page action button. r=flod

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8cb237283ed0