Report Site Issues in Page Action menu needs an ellipsis

RESOLVED FIXED

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: shorlander, Assigned: miketaylr)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Because the "Report Site Issue" button requires further input and takes you to a new page it should have an ellipsis at the end: Report Site Issue…
Cool, will do.
Assignee: nobody → miket
Attachment #8897965 - Flags: review?(shorlander) → review?(gijskruitbosch+bugs)
Attachment #8897965 - Flags: review?(gijskruitbosch+bugs) → review?(francesco.lodolo)
I think this will need a new entity, but I could be wrong. :flod will know for sure.
Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review176818

::: browser/extensions/webcompat-reporter/locales/en-US/webcompat.properties:8
(Diff revision 1)
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  # LOCALIZATION NOTE(wc-reporter.label): This string will be used in the
> -# Firefox menu panel below its button. Localized length should be considered.
> +# Firefox page actions menu. Localized length should be considered.
>  # \u00ad is included at the beginning of the string to disable auto-hyphens.
> -wc-reporter.label=\u00adReport Site Issue
> +wc-reporter.label=\u00adReport Site Issue…

You definitely need a new string ID for the added ellipsis, but since this is not the hamburger menu, you also don't need the \u00ad hack at the beginning.
Attachment #8897965 - Flags: review?(francesco.lodolo) → review-
Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review177762

That's.... embarassing. Apologies. (No more airport commits for me. >_<)
Comment on attachment 8897965 [details]
Bug 1390834. Add ellipsis to Report Site Issue page action button.

https://reviewboard.mozilla.org/r/169278/#review179380

Been there, done that when trying to rush things :-)
Attachment #8897965 - Flags: review?(francesco.lodolo) → review+
Thanks for review!

I'm gonna push w/o a try build since it's just a string change (and the wecompat-reporter tests are passing locally after building with this patch).
Pushed by mitaylor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cb237283ed0
Add ellipsis to Report Site Issue page action button. r=flod
https://hg.mozilla.org/mozilla-central/rev/8cb237283ed0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.