Fix the sidebar in about:telemetry

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: flyingrub, Assigned: flyingrub)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
The sidebar in about:telemetry can be scrolled horizontaly. We should not allow this.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8898305 [details]
Bug 1390835 - Fix the sidebar width in about:telemetry

https://reviewboard.mozilla.org/r/169674/#review174892

In what way does this stop the scrolling from happening?
Assignee

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8898305 [details]
Bug 1390835 - Fix the sidebar width in about:telemetry

https://reviewboard.mozilla.org/r/169674/#review174892

We now rely on a display: flex on the body. Before the .main-content with the width: 100% took all the space it could, interfering with the display: flex. (That's why I needed to add the min-width in the first place for .categories).

Comment 4

2 years ago
mozreview-review
Comment on attachment 8898305 [details]
Bug 1390835 - Fix the sidebar width in about:telemetry

https://reviewboard.mozilla.org/r/169674/#review175316
Attachment #8898305 - Flags: review?(chutten) → review+
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 0ba27bd2e3a2 -d 089706dfb481: rebasing 414587:0ba27bd2e3a2 "Bug 1390835 - Fix the sidebar width in about:telemetry r=chutten" (tip)
merging toolkit/content/aboutTelemetry.css
warning: conflicts while merging toolkit/content/aboutTelemetry.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 7

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f48a6466aa91
Fix the sidebar width in about:telemetry r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f48a6466aa91
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.