1390852 - Add missing generator * in calGoogleCalendar.js now causing test failures

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0

04:41:49     INFO -  PID 4344 | JavaScript strict warning: file:///C:/slave/test/build/application/thunderbird/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js, line 389: SyntaxError: yield is a reserved identifier
04:41:49     INFO -  PID 4344 | JavaScript error: file:///C:/slave/test/build/application/thunderbird/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js, line 389: SyntaxError: yield expression is only valid in generators

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1390852-generators.patch

I followed calendar/providers/caldav/calDavCalendar.js
  Task.spawn(function* () {
with a space after the *.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4b01552c32d5
Add missing generator * in calGoogleCalendar.js. rs=bustage-fix

Comment 3

[Jorg K (CEST = GMT+2)]

Tooru-san, can you please enlighten me here which M-C bug caused this?

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9ab2470a3210324bc11320531b15d195aa&tochange=6ebc251bd288c268b020815025b05854cc

Comment 4

[Tooru Fujisawa [:arai]]

would be bug 1390106

Comment 5

[:aceman]

I don't see how the calendar files were using JS versions, but we still have about 2 
<script type="application/javascript;version=..."> JS versions that we could remove.

Comment 6

[Jorg K (CEST = GMT+2)]

2, I see four plus one in suite:
https://dxr.mozilla.org/comm-central/search?q=%3Cscript+type%3D%22application%2Fjavascript%3Bversion%3D&redirect=false

Comment 7

[:aceman]

I skipped those that reference 3rd party libraries (like protovis) that may be version 1.8. But our internal code is always the latest version.

Comment 8

[:aceman]

We made the previous cleanup of versions in bug 1342806.