Closed Bug 1390852 Opened 2 years ago Closed 2 years ago

Add missing generator * in calGoogleCalendar.js now causing test failures

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk, Assigned: jorgk)

Details

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0

04:41:49     INFO -  PID 4344 | JavaScript strict warning: file:///C:/slave/test/build/application/thunderbird/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js, line 389: SyntaxError: yield is a reserved identifier
04:41:49     INFO -  PID 4344 | JavaScript error: file:///C:/slave/test/build/application/thunderbird/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js, line 389: SyntaxError: yield expression is only valid in generators
I followed calendar/providers/caldav/calDavCalendar.js
  Task.spawn(function* () {
with a space after the *.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4b01552c32d5
Add missing generator * in calGoogleCalendar.js. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Assignee: nobody → jorgk
Target Milestone: --- → 5.9
Tooru-san, can you please enlighten me here which M-C bug caused this?

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9ab2470a3210324bc11320531b15d195aa&tochange=6ebc251bd288c268b020815025b05854cc
Flags: needinfo?(arai.unmht)
would be bug 1390106
Flags: needinfo?(arai.unmht)
I don't see how the calendar files were using JS versions, but we still have about 2 
<script type="application/javascript;version=..."> JS versions that we could remove.
I skipped those that reference 3rd party libraries (like protovis) that may be version 1.8. But our internal code is always the latest version.
We made the previous cleanup of versions in bug 1342806.
You need to log in before you can comment on or make changes to this bug.