Improve TFO telemetry

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dragana, Assigned: dragana)

Tracking

55 Branch
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Created attachment 8898263 [details] [diff] [review]
bug_1390881_check_tfo_cookie_data_sent.patch
Attachment #8898263 - Flags: review?(mcmanus)
(Assignee)

Comment 2

a year ago
Created attachment 8898266 [details] [diff] [review]
bug_1390881_changeTelemetry.patch

One note:
linux will not accept data if it does not TFO cookie so telemetry with value  TFO_DATA_SENT will be the connections that have sent data. TFO_TRIED - the connection that only have sent the TFO cookie request.

Windows: getsockopt(TCP_FASTOPEN) returns 1 if the TFO cookie request or TFO data are sent. Therefore TFO_DATA_SENT will be the connections that have sent data or the TFO cookie request.
Attachment #8898266 - Flags: review?(mcmanus)
Attachment #8898263 - Flags: review?(mcmanus) → review+
Comment on attachment 8898266 [details] [diff] [review]
bug_1390881_changeTelemetry.patch

Review of attachment 8898266 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/TCPFastOpenLayer.h
@@ +29,5 @@
> +#define TFO_FAILED_CONNECTION_REFUSED_NO_TFO_FAILED_TOO 7
> +#define TFO_FAILED_NET_TIMEOUT__NO_TFO_FAILED_TOO       8
> +#define TFO_FAILED_UNKNOW_ERROR_NO_TFO_FAILED_TOO       9
> +#define TFO_FAILED_BACKUP_CONNECTION_NO_TFO_FAILED_TOO  10
> +#define TFO_FAILED                                      11

can you stick these in an enum so they don't pollute the pre-processor with unified builds?

::: netwerk/base/nsISocketTransport.idl
@@ +264,5 @@
>                            in long keepaliveRetryInterval);
>  
>      [noscript] void setFastOpenCallback(in TCPFastOpenPtr aFastOpen);
> +
> +    readonly attribute nsresult firstRetryError; 

whitespace nit
Attachment #8898266 - Flags: review?(mcmanus) → review+
(Assignee)

Comment 5

a year ago
Comment on attachment 8898266 [details] [diff] [review]
bug_1390881_changeTelemetry.patch

Can you please review telemetry part? Thank you
Attachment #8898266 - Flags: review?(francois)
Comment on attachment 8898266 [details] [diff] [review]
bug_1390881_changeTelemetry.patch

Review of attachment 8898266 [details] [diff] [review]:
-----------------------------------------------------------------

datareview+ but please add your own email to the list

::: toolkit/components/telemetry/Histograms.json
@@ +2550,5 @@
>      "expires_in_version": "61",
>      "kind": "enumerated",
> +    "n_values": 16,
> +    "description": "When a http connection is closed, track whether or not TCP Fast Open was used: 0=TFO_NOT_TRIED(There was no http connection and it was not TLS), 1=TFO_TRIED_NEGOTIATING, 2=TFO_DATA_SENT, 3=TFO_FAILED_CONNECTION_REFUSED, 4=TFO_FAILED_NET_TIMEOUT, 5=TFO_FAILED_UNKNOW_ERROR, 6=TFO_FAILED_BACKUP_CONNECTION, 7=TFO_FAILED_CONNECTION_REFUSED_NO_TFO_FAILED_TOO, 8=TFO_FAILED_NET_TIMEOUT__NO_TFO_FAILED_TOO, 9=TFO_FAILED_UNKNOW_ERROR_NO_TFO_FAILED_TOO, 10=TFO_FAILED_BACKUP_CONNECTION_NO_TFO_FAILED_TOO.",
> +    "alert_emails": ["necko@mozilla.com"],

We now ask people to add the address of a person to this list, so please add your email address to this list.

@@ +2563,1 @@
>      "alert_emails": ["necko@mozilla.com"],

Same here while we're at it.
Attachment #8898266 - Flags: review?(francois) → review+

Comment 7

a year ago
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77117a16d3c3
Check whether TFO cookie or TFO cookie and data are sent on Windows. r=mcmanus
https://hg.mozilla.org/integration/mozilla-inbound/rev/29b8fd865a47
Improve the TFO telemetry. r=mcmanus
https://hg.mozilla.org/mozilla-central/rev/77117a16d3c3
https://hg.mozilla.org/mozilla-central/rev/29b8fd865a47
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.