Closed Bug 1390967 Opened 7 years ago Closed 7 years ago

Selections in AB / Mail left panes: Wrong text color and missing blue background gradient on 10.9

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Version:
57 Branch
Platform:
x86
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr5256+ fixed, thunderbird56 fixed, thunderbird57 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 57.0
Tracking Flags:
Tracking Status
thunderbird_esr52 56+ fixed
thunderbird56 --- fixed
thunderbird57 --- fixed

People

(Reporter: stefanh, Assigned: stefanh)

Details

(Whiteboard: TB 56 beta 3 => TB 52.4.0 ESR)

Attachments

(1 file)

make text color always white and correct a style rule so we get the blue gradient in focused rows
2.72 KB, patch
Paenglab
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr52+
Details | Diff | Splinter Review 
(Richard and I talked about this yesterday).
Comment on attachment 8897937 [details] [diff] [review]
make text color always white and correct a style rule so we get the blue gradient in focused rows

Code looks good. I have no 10.9 and can't test it. But I'm sure you have done this.

Thanks a lot.
Attachment #8897937 - Flags: review?(richard.marti) → review+
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/comm-central/rev/0a4d72b6289d
Selections in AB / Mail left panes on 10.9: make text color always white and correct a style rule so we get the blue gradient in focused rows. r=Paenglab.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Stefan, I think it would be good uplift to beta and ESR. What do you think?
Target Milestone: --- → Thunderbird 57.0
Comment on attachment 8897937 [details] [diff] [review]
make text color always white and correct a style rule so we get the blue gradient in focused rows

(In reply to Richard Marti (:Paenglab) from comment #4)
> Stefan, I think it would be good uplift to beta and ESR. What do you think?

Yes, I agree.

[Approval Request Comment]
User impact if declined: Bad ui experience for 10.9 users when using AB / Mail left panes
Testing completed (on c-c, etc.): just landed on c-c
Risk to taking this patch (and alternatives if risky): Very  low risk, only css changes.
Attachment #8897937 - Flags: approval-comm-esr52?
Attachment #8897937 - Flags: approval-comm-beta?
Comment on attachment 8897937 [details] [diff] [review]
make text color always white and correct a style rule so we get the blue gradient in focused rows

(In reply to Stefan [:stefanh] from comment #5)
> Risk to taking this patch (and alternatives if risky): Very low risk, only
> css changes.
That's Richard's phrase, but I can destroy the program with on line of CSS ;-(
Attachment #8897937 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #8897937 - Flags: approval-comm-esr52? → approval-comm-esr52+
Whiteboard: TB 56 beta 3 => TB 52.4.0 ESR
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: