Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
This macro hasn't done anything special for a while, so just replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED.
Comment hidden (mozreview-request)
Assignee

Comment 2

2 years ago
(In reply to Andrew McCreight [:mccr8] from comment #0)
> This macro hasn't done anything special for a while, so just replace it with
> NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED.
Err.. with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION. I used find and sed to generate this patch, then I skimmed it over. L64 debug looks green.

Comment 3

2 years ago
mozreview-review
Comment on attachment 8898041 [details]
Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED.

https://reviewboard.mozilla.org/r/169344/#review178640

Hopefully we won't regret this in the future :-).
Attachment #8898041 - Flags: review?(peterv) → review+
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71882fd33c91
Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
https://hg.mozilla.org/mozilla-central/rev/71882fd33c91
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.