Closed
Bug 1391005
Opened 7 years ago
Closed 7 years ago
Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
This macro hasn't done anything special for a while, so just replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #0) > This macro hasn't done anything special for a while, so just replace it with > NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. Err.. with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION. I used find and sed to generate this patch, then I skimmed it over. L64 debug looks green.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8898041 [details] Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. https://reviewboard.mozilla.org/r/169344/#review178640 Hopefully we won't regret this in the future :-).
Attachment #8898041 -
Flags: review?(peterv) → review+
| Comment hidden (mozreview-request) |
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/71882fd33c91 Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/71882fd33c91
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•