Closed
Bug 1391042
Opened 7 years ago
Closed 7 years ago
TypeError: this.appMenuStatus is null in browser-sync
Categories
(Firefox :: Sync, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: eoger, Assigned: eoger)
References
Details
Attachments
(1 file)
This is a regression from bug 1390273, turns out |!window.toolbar.visible| also helped with the macOS hidden window.
|
||
Comment 1•7 years ago
|
||
:-( Sorry for totally not realizing that in review.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•7 years ago
|
||
No worries, I guess it was a side-effect of the patch that introduced that code.
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897999 [details] Bug 1391042 - Don't load Sync UI for hidden windows. https://reviewboard.mozilla.org/r/169302/#review174636
Attachment #8897999 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e27dfd3b9ce4 Don't load Sync UI for hidden windows. r=Gijs
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e27dfd3b9ce4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•