1391127 - Build error in Brotli: log2 not found in MinGW Build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

> backward_references_hq.c:(.text+0x104): undefined reference to `log2'

I believe this is an upstream bug related to their #if here: https://github.com/google/brotli/blob/master/c/enc/fast_log.h#L131

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I take it back, mingw does have log2, so I probably need to add a -lm or something somewhere...

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1391127 Add -lm for brotli when compiling with gcc for Windows

Review commit: https://reviewboard.mozilla.org/r/169678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169678/

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8898330 [details]
Bug 1391127 Add -lm for brotli when compiling with gcc for Windows

https://reviewboard.mozilla.org/r/169678/#review174920

Seems OK to me, but as this is a moz.build thing, we should probably ask :glandium for the actual r+, in case there's some better way to do it...

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8898330 [details]
Bug 1391127 Add -lm for brotli when compiling with gcc for Windows

https://reviewboard.mozilla.org/r/169678/#review175252

::: modules/brotli/moz.build:57
(Diff revision 1)
>      'enc/static_dict.c',
>      'enc/utf8_util.c',
>      'tools/bro.c',
>  ]
>  
> -if CONFIG['OS_TARGET'] != 'WINNT':
> +if CONFIG['OS_TARGET'] != 'WINNT' or CONFIG['CC_TYPE'] == 'gcc':

err, in fact, CONFIG['OS_TARGET'] is wrong here too.
All in all the right test here would be CONFIG['HOST_CC_TYPE'] not in ('msvc', 'clang-cl')

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8898330 [details]
Bug 1391127 Add -lm for brotli when compiling with gcc for Windows

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169678/diff/1-2/

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Try run is okay (excepting broken buildbot).

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8898330 [details]
Bug 1391127 Add -lm for brotli when compiling with gcc for Windows

https://reviewboard.mozilla.org/r/169678/#review176096

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45976ebf90f7
Add -lm for brotli when compiling with gcc for Windows r=glandium

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/45976ebf90f7