Don't retain WebRenderUserData unconditionally.

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: mtseng, Assigned: mtseng)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

In some case, we'll reset compositor (e.g. device reset). Thus, we shouldn't retain WebRenderUserData because if we retain, we'll get wrong data. This bug will add some check when retaining WebRenderUserData.
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8898084 [details]
Bug 1391135 - Only retain WebRenderUserData when layer manager and namespaceID is match.

https://reviewboard.mozilla.org/r/169412/#review174870

::: gfx/layers/wr/WebRenderUserData.cpp:30
(Diff revision 1)
>  }
>  
> +bool
> +WebRenderUserData::IsDataValid(WebRenderLayerManager* aManager)
> +{
> +  return aManager == mWRManager &&

If aManager == mWRManager here then their wrbridges are also going to be == and the namespaces are also going to be ==. So that part of the check seems redundant. This is effectively only checking to make sure the layermanager is the same. r=me if you remove the second part of the check as it is unnecessary.
Attachment #8898084 - Flags: review?(bugmail) → review+
Thanks for review. I'll remove pipeline id check.

Comment 5

5 months ago
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cbc5c672ea4
Only retain WebRenderUserData when layer manager and namespaceID is match. r=kats

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7cbc5c672ea4
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.