Handle WebGL context lost in layers-free mode.

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mtseng, Assigned: mtseng)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Originally, we check IsContextLost in WebGLContext::GetCanvasLayer(). However, in layers-free mode, we don't use GetCanvasLayer, we'll call InitializeCanvasRenderer. So I move IsContextLost check to InitializeCanvasRenderer.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8898085 [details]
Bug 1391136 - Handle context lost in layers-free mode.

https://reviewboard.mozilla.org/r/169416/#review174992

::: layout/generic/nsHTMLCanvasFrame.cpp:144
(Diff revision 1)
>            aManager->CreateOrRecycleWebRenderUserData<WebRenderCanvasData>(this, &isRecycled);
>          WebRenderCanvasRendererAsync* data =
>            static_cast<WebRenderCanvasRendererAsync*>(canvasData->GetCanvasRenderer());
>  
>          if (!isRecycled) {
> -          static_cast<nsHTMLCanvasFrame*>(mFrame)->InitializeCanvasRenderer(aDisplayListBuilder, data);
> +          nsHTMLCanvasFrame *canvasFrame = static_cast<nsHTMLCanvasFrame*>(mFrame);

Star to the left, against the type.
Attachment #8898085 - Flags: review?(jgilbert) → review+

Comment 4

a year ago
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/682c2b840724
Handle context lost in layers-free mode. r=jgilbert

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/682c2b840724
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.