1391142 - Remove MediaResource::IsLiveStream()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/5ce320a16f6998dc2b36e30458131d029d107077/dom/media/MediaDecoderStateMachine.cpp#2484

MDSM is the only caller which checks IsLiveStream() to determine whether seek has reached the end of the resource.

We want to remove the dependency on MediaResource from MDSM since MediaResource should be an internal detail of MediaDecoder. I will add a UpdateIsLiveStream() function to MDSM so MediaDecoder can call it to update the status of live stream.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1391142. P1 - dispatch IsLiveStream changes from MediaDecoder to MDSM.

This allows us to remove the dependency on MediaResource from MDSM in P2.

Review commit: https://reviewboard.mozilla.org/r/170004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170004/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1391142. P2 - remove MDSM::mResource and related functions.

Review commit: https://reviewboard.mozilla.org/r/170006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170006/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1391142. P3 - remove IsLiveStream() from MediaResource.

Review commit: https://reviewboard.mozilla.org/r/170008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170008/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8898616 [details]
Bug 1391142. P1 - dispatch IsLiveStream changes from MediaDecoder to MDSM.

https://reviewboard.mozilla.org/r/170004/#review176166

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8898617 [details]
Bug 1391142. P2 - remove MDSM::mResource and related functions.

https://reviewboard.mozilla.org/r/170006/#review176168

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8898618 [details]
Bug 1391142. P3 - remove IsLiveStream() from MediaResource.

https://reviewboard.mozilla.org/r/170008/#review176170

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ee6c8012b97
P1 - dispatch IsLiveStream changes from MediaDecoder to MDSM. r=gerald
https://hg.mozilla.org/integration/autoland/rev/332a6f47a270
P2 - remove MDSM::mResource and related functions. r=gerald
https://hg.mozilla.org/integration/autoland/rev/7518bf7c05bc
P3 - remove IsLiveStream() from MediaResource. r=gerald

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5ee6c8012b97
https://hg.mozilla.org/mozilla-central/rev/332a6f47a270
https://hg.mozilla.org/mozilla-central/rev/7518bf7c05bc