Add checkLoadURL fast path for extension URLs

RESOLVED FIXED in Firefox 57

Status

enhancement
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We call checkLoadURL *a lot*, and the for the extremely common case of checking an extension URL, a simple substring check is orders of magnitude cheaper than creating a nsIURI and going through the security manager.
(Assignee)

Updated

2 years ago
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8898126 [details]
Bug 1391158: Optimize checkLoadURL for the common case of extension URLs.

https://reviewboard.mozilla.org/r/169474/#review174914
Attachment #8898126 - Flags: review?(mixedpuppy) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee33fed596af4461bc2e30fede68dba2c90596c3
Bug 1391158: Optimize checkLoadURL for the common case of extension URLs. r=mixedpuppy

Comment 4

2 years ago
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee33fed596af
Optimize checkLoadURL for the common case of extension URLs. r=mixedpuppy

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ee33fed596af
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Updated

10 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.