Closed Bug 1391174 Opened 3 years ago Closed 2 years ago

[nb-NO] L10n of SeaMonkey in nb-NO has been resumed and completed

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set

Tracking

(seamonkey2.49esr fixed, seamonkey2.50 wontfix, seamonkey2.51 wontfix, seamonkey2.52 wontfix, seamonkey2.53 wontfix, seamonkey2.54 wontfix, seamonkey2.55 wontfix, seamonkey2.56 fixed)

RESOLVED FIXED
seamonkey2.56
Tracking Status
seamonkey2.49esr --- fixed
seamonkey2.50 --- wontfix
seamonkey2.51 --- wontfix
seamonkey2.52 --- wontfix
seamonkey2.53 --- wontfix
seamonkey2.54 --- wontfix
seamonkey2.55 --- wontfix
seamonkey2.56 --- fixed

People

(Reporter: havarh, Assigned: havarh)

References

Details

Attachments

(3 files, 5 obsolete files)

Hello.
I have just resumed the l10n of SeaMonkey in nb-NO, and want the language to be added back in the build config if there aren't any build errors.
I'm using Pontoon for the l10n work, and I've just fixed the 3 warnings mentioned here:
https://l10n.mozilla.org/dashboard/compare?run=781144
I have no way of working on region.properties since the file is not available in Pontoon, and I don't have access to the file in HG, nor can I remove the obsolete strings or files.
I could help you with the region.properties access in HG. You can provide a patch (I can send you the current version if you need it) and ask any l10n-driver to review the patch and give me permissions so I can land it for you.
I can review the correctness (but not the translation) of the region.properties patch
I might be able to land it too.
Håvar,

great. We are currently trying to get SeaMonkey 2.49.1 out of the door which is done from the esr52 release branch. If you want I can try to make a patch from 2.54 which can be transplanted to the 2.49.1. Not sure if this can be down with pontoon.
Attached patch Patch for region.properties (obsolete) — Splinter Review
Patch for updated region.properties.
(In reply to [:rickiees] Ricardo Palomares from comment #1)
> I could help you with the region.properties access in HG. You can provide a
> patch (I can send you the current version if you need it) and ask any
> l10n-driver to review the patch and give me permissions so I can land it for
> you.
OK. I don't think I need HG access, because I rarely need to edit files in HG (I hope). I've added the patch.

(In reply to Ian Neal from comment #2)
> I can review the correctness (but not the translation) of the
> region.properties patch
> I might be able to land it too.
Great.

(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> Håvar,
> 
> great. We are currently trying to get SeaMonkey 2.49.1 out of the door which
> is done from the esr52 release branch. If you want I can try to make a patch
> from 2.54 which can be transplanted to the 2.49.1. Not sure if this can be
> down with pontoon.
OK. It would've been great if you could try that.
Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

Review of attachment 8899978 [details] [diff] [review]:
-----------------------------------------------------------------

Asking for review
Attachment #8899978 - Flags: review?(iann_bugzilla)
I'm still a Bugzilla newbie, so I'm not sure if I did ask for review the right way.
Attached patch nb-NO-2491.patch (obsolete) — Splinter Review
Håvar please check the patch with a text editor. I compiled a 2.49.1 SeaMonkey and see no errors with merge but there is at least one untranslated english string in it.

If you find others just let me know all translations and I will update it.
Flags: needinfo?(havar)
For reference. The current esr52 branch ends at cset (c84b8fb6b939) [nb-NO] update from Pootle (lightning)

Oh btw. ChatZilla is missing a few string in comm-central too. I set them to ??? but they are not important for 2.49.1
Attached patch 1391174-region.patch (obsolete) — Splinter Review
Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

I think you picked the wrong file. Mail is Thunderbird only. Check the patch I just uploadad and ask for review for this one instead if you think it is ok.
Attachment #8899978 - Flags: feedback-
Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

Review of attachment 8899978 [details] [diff] [review]:
-----------------------------------------------------------------

This is the right file
(In reply to Frank-Rainer Grahl (:frg) from comment #11)
> Comment on attachment 8899978 [details] [diff] [review]
> Patch for region.properties
> 
> I think you picked the wrong file. Mail is Thunderbird only. Check the patch
> I just uploadad and ask for review for this one instead if you think it is
> ok.
Oops. Yes, you're right. Well, actually I cheated a bit here. I edited the right file, and then made two directories a/mail/chrome/messenger-region/ and b/mail/chrome/messenger-region/ and then just did a git diff on those directories. But I used the wrong name for the directories.

(In reply to Frank-Rainer Grahl (:frg) from comment #9)
> For reference. The current esr52 branch ends at cset (c84b8fb6b939) [nb-NO]
> update from Pootle (lightning)
> 
> Oh btw. ChatZilla is missing a few string in comm-central too. I set them to
> ??? but they are not important for 2.49.1
OK. I didn't find ChatZilla in Pontoon.

(In reply to Frank-Rainer Grahl (:frg) from comment #8)
> Created attachment 8900000 [details] [diff] [review]
> nb-NO-2491.patch
> 
> Håvar please check the patch with a text editor. I compiled a 2.49.1
> SeaMonkey and see no errors with merge but there is at least one
> untranslated english string in it.
> 
> If you find others just let me know all translations and I will update it.

OK. I've reviewed the file. I cheated again, and edited the patch directly. Hope that's OK? I'll upload the new patch with some fixes.
Flags: needinfo?(havar)
Attached patch fixed-nb-NO-2491.patch (obsolete) — Splinter Review
Updated patch, edited manually.
Attached patch 1391174-nb-NO-2491-V2.patch (obsolete) — Splinter Review
Looks good. No errors in l10n-merge and for esr52 2.49.x release branch only
Attachment #8900000 - Attachment is obsolete: true
Attachment #8900021 - Attachment is obsolete: true
Attachment #8900219 - Flags: review+
Attachment #8900219 - Flags: approval-comm-esr52?
Add nb-NO back to shipped locales in suite. 

Should it go into the SeaMonkey comm-esr52 release branch or into default there? The changed strings can only go into the relbranch obviously.
Attachment #8900220 - Flags: review?(iann_bugzilla)
Attachment #8900220 - Flags: approval-comm-esr52?
Assignee: nobody → havar
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

As frg said
Attachment #8899978 - Flags: review?(iann_bugzilla) → review-
Attachment #8900014 - Flags: review+
Comment on attachment 8900219 [details] [diff] [review]
1391174-nb-NO-2491-V2.patch

>+++ b/editor/ui/chrome/dialogs/EditorImageProperties.dtd
>@@ -72,8 +72,10 @@
> <!ENTITY LinkAdvancedEditButton.tooltip "Legg til eller endre HTML-attributter, stilattributter og JavaScript">
> <!-- These tabs are currently used in the image input dialog -->
> 
> <!ENTITY imageInputTab.label "Skjema">
> <!ENTITY imageLocationTab.label "Adresse">
> <!ENTITY imageDimensionsTab.label "Størrelsesforhold">
> <!ENTITY imageAppearanceTab.label "Utseende">
> <!ENTITY imageLinkTab.label "Lenke">
>+
>+<!ENTITY locationEditField.shortenedDataURI "Shortened data URI (copy will place the full URI onto the clipboard)">
Needs translation?

r/a=me with that answered
Flags: needinfo?(havar)
Attachment #8900219 - Flags: approval-comm-esr52? → approval-comm-esr52+
Comment on attachment 8900220 [details] [diff] [review]
1391174-suite.patch

LGTM r/a=me
Attachment #8900220 - Flags: review?(iann_bugzilla)
Attachment #8900220 - Flags: review+
Attachment #8900220 - Flags: approval-comm-esr52?
Attachment #8900220 - Flags: approval-comm-esr52+
Patch updated r+ from IanN retained. I overlooked this when assembling and reviewing the patch. I took the variable (actually the whole file because it was ok) from l10n-central. Håvar could you doublecheck editor/ui/chrome/dialogs/EditorImageProperties.dtd to be sure.

IanN could you set a+ again. I don't have the rights. Thanks.
Attachment #8900219 - Attachment is obsolete: true
Attachment #8900937 - Flags: review+
Attachment #8900937 - Flags: approval-comm-esr52?
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/428c1ea1553b
Add nb-NO to SeaMonkey shipped locales. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Comment on attachment 8900937 [details] [diff] [review]
1391174-nb-NO-2491-V2a.patch

Carrying forward a=me
Attachment #8900937 - Flags: approval-comm-esr52? → approval-comm-esr52+
(In reply to Frank-Rainer Grahl (:frg) from comment #21)
> Created attachment 8900937 [details] [diff] [review]
> 1391174-nb-NO-2491-V2a.patch
> 
> Patch updated r+ from IanN retained. I overlooked this when assembling and
> reviewing the patch. I took the variable (actually the whole file because it
> was ok) from l10n-central. Håvar could you doublecheck
> editor/ui/chrome/dialogs/EditorImageProperties.dtd to be sure.
OK. Thank you for fixing that string, I had overlooked it.
I have doublechecked the file, and it seems to be OK.
Flags: needinfo?(havar)
I changed the comment for checkin. r+ from IanN retained.

Ian, could you push this to l10n-central. I tried and do not have the rights.
Attachment #8899978 - Attachment is obsolete: true
Attachment #8900014 - Attachment is obsolete: true
Flags: needinfo?(iann_bugzilla)
Attachment #8903209 - Flags: review+
Comment on attachment 8900220 [details] [diff] [review]
1391174-suite.patch

Checked into comm-esr52 SEAMONKEY_2_49_ESR_RELBRANCH only.

https://hg.mozilla.org/releases/comm-esr52/rev/595a41106f75d9e2950efd0d2c83de191cfb4665
Comment on attachment 8900937 [details] [diff] [review]
1391174-nb-NO-2491-V2a.patch

Same her. No rights for
ssh://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO

Could you push this too. Its needs to go into a new branch named SEAMONKEY_2_49_ESR_RELBRANCH

The branch needs to be on top of changeset:
Changeset: 3316 (c84b8fb6b939) [nb-NO] update from Pootle (lightning)
(In reply to Frank-Rainer Grahl (:frg) from comment #27)
> Comment on attachment 8900937 [details] [diff] [review]
> 1391174-nb-NO-2491-V2a.patch
> 
> Same her. No rights for
> ssh://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO
> 
> Could you push this too. Its needs to go into a new branch named
> SEAMONKEY_2_49_ESR_RELBRANCH
> 
> The branch needs to be on top of changeset:
> Changeset: 3316 (c84b8fb6b939) [nb-NO] update from Pootle (lightning)

https://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO/rev/f2744e053a8c8ca67e17945ec80a2cce79380276
Flags: needinfo?(iann_bugzilla)
Comment on attachment 8903209 [details] [diff] [review]
1391174-region.patch

Ian, the 1391174-region.patch still needs a checkin into nb-NO l10n central. Could you do this? I think the bug can then be closed.
Flags: needinfo?(iann_bugzilla)
Ricardo, can you do this?
Flags: needinfo?(iann_bugzilla) → needinfo?(rpmdisguise-nave)
Yes, it seems I can do it: :-)

https://hg.mozilla.org/l10n-central/nb-NO/rev/305af302f83295b66c927e53d509c53f499701b7

frg, I don't know if the bug is now ready to be closed, or there are some further modifications.
Flags: needinfo?(rpmdisguise-nave)
No should be fine now. 2.57 as a target is not yet there. I am setting 2.56 as target for now. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Seamonkey2.56
You need to log in before you can comment on or make changes to this bug.