1391174 - [nb-NO] L10n of SeaMonkey in nb-NO has been resumed and completed

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Håvar I. Henriksen [:havarh]]

Hello.
I have just resumed the l10n of SeaMonkey in nb-NO, and want the language to be added back in the build config if there aren't any build errors.
I'm using Pontoon for the l10n work, and I've just fixed the 3 warnings mentioned here:
https://l10n.mozilla.org/dashboard/compare?run=781144
I have no way of working on region.properties since the file is not available in Pontoon, and I don't have access to the file in HG, nor can I remove the obsolete strings or files.

Comment 1

[RickieES aka Ricardo Palomares]

I could help you with the region.properties access in HG. You can provide a patch (I can send you the current version if you need it) and ask any l10n-driver to review the patch and give me permissions so I can land it for you.

Comment 2

[Ian Neal]

I can review the correctness (but not the translation) of the region.properties patch
I might be able to land it too.

Comment 3

[Frank-Rainer Grahl (:frg)]

Håvar,

great. We are currently trying to get SeaMonkey 2.49.1 out of the door which is done from the esr52 release branch. If you want I can try to make a patch from 2.54 which can be transplanted to the 2.49.1. Not sure if this can be down with pontoon.

Comment 4

[Håvar I. Henriksen [:havarh]]

Attachment: Patch for region.properties

Patch for updated region.properties.

Comment 5

[Håvar I. Henriksen [:havarh]]

(In reply to [:rickiees] Ricardo Palomares from comment #1)
> I could help you with the region.properties access in HG. You can provide a
> patch (I can send you the current version if you need it) and ask any
> l10n-driver to review the patch and give me permissions so I can land it for
> you.
OK. I don't think I need HG access, because I rarely need to edit files in HG (I hope). I've added the patch.

(In reply to Ian Neal from comment #2)
> I can review the correctness (but not the translation) of the
> region.properties patch
> I might be able to land it too.
Great.

(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> Håvar,
> 
> great. We are currently trying to get SeaMonkey 2.49.1 out of the door which
> is done from the esr52 release branch. If you want I can try to make a patch
> from 2.54 which can be transplanted to the 2.49.1. Not sure if this can be
> down with pontoon.
OK. It would've been great if you could try that.

Comment 6

[Håvar I. Henriksen [:havarh]]

Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

Review of attachment 8899978 [details] [diff] [review]:
-----------------------------------------------------------------

Asking for review

Comment 7

[Håvar I. Henriksen [:havarh]]

I'm still a Bugzilla newbie, so I'm not sure if I did ask for review the right way.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: nb-NO-2491.patch

Håvar please check the patch with a text editor. I compiled a 2.49.1 SeaMonkey and see no errors with merge but there is at least one untranslated english string in it.

If you find others just let me know all translations and I will update it.

Comment 9

[Frank-Rainer Grahl (:frg)]

For reference. The current esr52 branch ends at cset (c84b8fb6b939) [nb-NO] update from Pootle (lightning)

Oh btw. ChatZilla is missing a few string in comm-central too. I set them to ??? but they are not important for 2.49.1

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1391174-region.patch

Comment 11

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

I think you picked the wrong file. Mail is Thunderbird only. Check the patch I just uploadad and ask for review for this one instead if you think it is ok.

Comment 12

[Håvar I. Henriksen [:havarh]]

Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

Review of attachment 8899978 [details] [diff] [review]:
-----------------------------------------------------------------

This is the right file

Comment 13

[Håvar I. Henriksen [:havarh]]

(In reply to Frank-Rainer Grahl (:frg) from comment #11)
> Comment on attachment 8899978 [details] [diff] [review]
> Patch for region.properties
> 
> I think you picked the wrong file. Mail is Thunderbird only. Check the patch
> I just uploadad and ask for review for this one instead if you think it is
> ok.
Oops. Yes, you're right. Well, actually I cheated a bit here. I edited the right file, and then made two directories a/mail/chrome/messenger-region/ and b/mail/chrome/messenger-region/ and then just did a git diff on those directories. But I used the wrong name for the directories.

(In reply to Frank-Rainer Grahl (:frg) from comment #9)
> For reference. The current esr52 branch ends at cset (c84b8fb6b939) [nb-NO]
> update from Pootle (lightning)
> 
> Oh btw. ChatZilla is missing a few string in comm-central too. I set them to
> ??? but they are not important for 2.49.1
OK. I didn't find ChatZilla in Pontoon.

(In reply to Frank-Rainer Grahl (:frg) from comment #8)
> Created attachment 8900000 [details] [diff] [review]
> nb-NO-2491.patch
> 
> Håvar please check the patch with a text editor. I compiled a 2.49.1
> SeaMonkey and see no errors with merge but there is at least one
> untranslated english string in it.
> 
> If you find others just let me know all translations and I will update it.

OK. I've reviewed the file. I cheated again, and edited the patch directly. Hope that's OK? I'll upload the new patch with some fixes.

Comment 14

[Håvar I. Henriksen [:havarh]]

Attachment: fixed-nb-NO-2491.patch

Updated patch, edited manually.

Comment 15

[Frank-Rainer Grahl (:frg)]

> I edited the right file, 

According to 
 https://l10n.mozilla.org/dashboard/compare?run=783891
4 strings are missing. 

I compared 
 https://hg.mozilla.org/comm-central/file/tip/suite/locales/en-US/chrome/mailnews/region.properties
and
 https://hg.mozilla.org/l10n-central/nb-NO/file/tip/suite/chrome/mailnews/region.properties

Check attachment
 https://bug1391174.bmoattachments.org/attachment.cgi?id=8900014

and if you think it is ok just ask for review.

Will check the revised big patch next.

Comment 16

[Frank-Rainer Grahl (:frg)]

Attachment: 1391174-nb-NO-2491-V2.patch

Looks good. No errors in l10n-merge and for esr52 2.49.x release branch only

Comment 17

[Frank-Rainer Grahl (:frg)]

Attachment: 1391174-suite.patch

Add nb-NO back to shipped locales in suite. 

Should it go into the SeaMonkey comm-esr52 release branch or into default there? The changed strings can only go into the relbranch obviously.

Comment 18

[Ian Neal]

Comment on attachment 8899978 [details] [diff] [review]
Patch for region.properties

As frg said

Comment 19

[Ian Neal]

Comment on attachment 8900219 [details] [diff] [review]
1391174-nb-NO-2491-V2.patch

>+++ b/editor/ui/chrome/dialogs/EditorImageProperties.dtd
>@@ -72,8 +72,10 @@
> <!ENTITY LinkAdvancedEditButton.tooltip "Legg til eller endre HTML-attributter, stilattributter og JavaScript">
> <!-- These tabs are currently used in the image input dialog -->
> 
> <!ENTITY imageInputTab.label "Skjema">
> <!ENTITY imageLocationTab.label "Adresse">
> <!ENTITY imageDimensionsTab.label "Størrelsesforhold">
> <!ENTITY imageAppearanceTab.label "Utseende">
> <!ENTITY imageLinkTab.label "Lenke">
>+
>+<!ENTITY locationEditField.shortenedDataURI "Shortened data URI (copy will place the full URI onto the clipboard)">
Needs translation?

r/a=me with that answered

Comment 20

[Ian Neal]

Comment on attachment 8900220 [details] [diff] [review]
1391174-suite.patch

LGTM r/a=me

Comment 21

[Frank-Rainer Grahl (:frg)]

Attachment: 1391174-nb-NO-2491-V2a.patch

Patch updated r+ from IanN retained. I overlooked this when assembling and reviewing the patch. I took the variable (actually the whole file because it was ok) from l10n-central. Håvar could you doublecheck editor/ui/chrome/dialogs/EditorImageProperties.dtd to be sure.

IanN could you set a+ again. I don't have the rights. Thanks.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/428c1ea1553b
Add nb-NO to SeaMonkey shipped locales. r=IanN

Comment 23

[Ian Neal]

Comment on attachment 8900937 [details] [diff] [review]
1391174-nb-NO-2491-V2a.patch

Carrying forward a=me

Comment 24

[Håvar I. Henriksen [:havarh]]

(In reply to Frank-Rainer Grahl (:frg) from comment #21)
> Created attachment 8900937 [details] [diff] [review]
> 1391174-nb-NO-2491-V2a.patch
> 
> Patch updated r+ from IanN retained. I overlooked this when assembling and
> reviewing the patch. I took the variable (actually the whole file because it
> was ok) from l10n-central. Håvar could you doublecheck
> editor/ui/chrome/dialogs/EditorImageProperties.dtd to be sure.
OK. Thank you for fixing that string, I had overlooked it.
I have doublechecked the file, and it seems to be OK.

Comment 25

[Frank-Rainer Grahl (:frg)]

Attachment: 1391174-region.patch

I changed the comment for checkin. r+ from IanN retained.

Ian, could you push this to l10n-central. I tried and do not have the rights.

Comment 26

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8900220 [details] [diff] [review]
1391174-suite.patch

Checked into comm-esr52 SEAMONKEY_2_49_ESR_RELBRANCH only.

https://hg.mozilla.org/releases/comm-esr52/rev/595a41106f75d9e2950efd0d2c83de191cfb4665

Comment 27

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8900937 [details] [diff] [review]
1391174-nb-NO-2491-V2a.patch

Same her. No rights for
ssh://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO

Could you push this too. Its needs to go into a new branch named SEAMONKEY_2_49_ESR_RELBRANCH

The branch needs to be on top of changeset:
Changeset: 3316 (c84b8fb6b939) [nb-NO] update from Pootle (lightning)

Comment 28

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #27)
> Comment on attachment 8900937 [details] [diff] [review]
> 1391174-nb-NO-2491-V2a.patch
> 
> Same her. No rights for
> ssh://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO
> 
> Could you push this too. Its needs to go into a new branch named
> SEAMONKEY_2_49_ESR_RELBRANCH
> 
> The branch needs to be on top of changeset:
> Changeset: 3316 (c84b8fb6b939) [nb-NO] update from Pootle (lightning)

https://hg.mozilla.org/releases/l10n/mozilla-release/nb-NO/rev/f2744e053a8c8ca67e17945ec80a2cce79380276

Comment 29

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8903209 [details] [diff] [review]
1391174-region.patch

Ian, the 1391174-region.patch still needs a checkin into nb-NO l10n central. Could you do this? I think the bug can then be closed.

Comment 30

[Ian Neal]

Ricardo, can you do this?

Comment 31

[RickieES aka Ricardo Palomares]

Yes, it seems I can do it: :-)

https://hg.mozilla.org/l10n-central/nb-NO/rev/305af302f83295b66c927e53d509c53f499701b7

frg, I don't know if the bug is now ready to be closed, or there are some further modifications.

Comment 32

[Frank-Rainer Grahl (:frg)]

No should be fine now. 2.57 as a target is not yet there. I am setting 2.56 as target for now. Thanks.