Closed Bug 1391295 Opened 2 years ago Closed 2 years ago

Startup crash after starting (but not finishing) the Leanplum notification priming

Categories

(Firefox for iOS :: General, defect, critical)

All
iOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Iteration:
1.28
Tracking Status
fxios ? ---

People

(Reporter: jcollings, Assigned: jhugman)

Details

(Keywords: crash, steps-wanted, Whiteboard: [MobileCore][MMA][Onboarding])

Attachments

(2 files)

iOS Beta 9.0

Steps:
1. I updated Test Flight to get Beta 9.0
2. I sent a pre push opt-in dialog from Leanplum to my Beta 9.0 app
3. I clicked yes to the pre push dialog
4. When the Apple push notification prompt appeared, I didn't click on the yes or no button, I went ahead and clicked on the home button to get out of the experience
5. The next time and thereafter, anytime I try to open the Beta 9.0 app, it keeps on crashing and closing 

Notes:
I also went to the Test Flight app to open Beta 9.0 in there and it just went back to my home screen. 

I don't know if it's because I didn't answer Apple's push notification prompt that is causing the crash or if it's just my app. 


Let me know if you need more information!

Jean
Summary: Beta 9.0 Crashes Every Time I Try To Open It → Crash after starting (but not finishing) the Leanplum notification priming
Summary: Crash after starting (but not finishing) the Leanplum notification priming → Startup crash after starting (but not finishing) the Leanplum notification priming
Thread 3 name: Dispatch queue: com.apple.root.default-qos
Thread 3 Crashed:
0 Client 0x0000000100090b8c specialized specialized FxALoginHelper.(apnsRegisterDidSucceed(Data) -> ()).(closure #1) (FxALoginHelper.swift:243)
1 Client 0x000000010008e3a4 FxALoginHelper.(apnsRegisterDidSucceed(Data) -> ()).(closure #1) (FxALoginHelper.swift:0)
2 Deferred 0x000000010120c0b8 0x101200000 + 49336
3 Deferred 0x000000010120c1b8 0x101200000 + 49592
4 Deferred 0x000000010120aab4 0x101200000 + 43700
5 Deferred 0x000000010120c210 0x101200000 + 49680
6 Deferred 0x0000000101207e64 0x101200000 + 32356
7 libdispatch.dylib 0x0000000181f45200 0x181f44000 + 4608
8 libdispatch.dylib 0x0000000181f451c0 0x181f44000 + 4544
9 libdispatch.dylib 0x0000000181f53ab4 0x181f44000 + 64180
10 libdispatch.dylib 0x0000000181f5538c 0x181f44000 + 70540
11 libdispatch.dylib 0x0000000181f550ec 0x181f44000 + 69868
12 libsystem_pthread.dylib 0x000000018214e2b8 0x18214d000 + 4792
13 libsystem_pthread.dylib 0x000000018214dda4 0x18214d000 + 3492
Attached file 8.3 Crash
Stefan 8.3 is still crashing - here is the stack trace.
Need one of you two to symbolicate this crash to see what's up now.
Flags: needinfo?(sarentz)
Flags: needinfo?(jhugman)
Severity: normal → critical
tracking-fxios: --- → ?
Component: Build & Test → General
Keywords: crash, steps-wanted
Hardware: Other → All
The patch for Bug 1390126 has not made it to v9.x or master yet.

Secondly: LeanPlum is doing something strange: it is registering for APNS _after_ the first dialog is answered, and _before_ iOS's own dialog. This means that there are two registrations for APNS being done, which is causing us to crash once iOS dialog has been accepted.

I have fixed this with the attached PR. 

I have been unable reproduce the existing STR in Comment 0.
Flags: needinfo?(jhugman)
Attachment #8899545 - Flags: review?(sarentz)
Whiteboard: [Needsuplift][v9.x][master]
Comment on attachment 8899545 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3072

Looks good to me. Is there an underlying reason for the deferred to already be filled? Is this the right place to fix this?
Flags: needinfo?(sarentz)
Attachment #8899545 - Flags: review?(sarentz) → review+
Attachment #8899545 - Flags: review?(sdaswani)
Merged into v8.x.

Uplifting with Bug 1390126 to master and v9.x
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Merged into master. Uplifted to 9.x 43675480daac8dfc588e92c80a318c0e448a37c4
Iteration: --- → 1.28
Assignee: sarentz → jhugman
Whiteboard: [Needsuplift][v9.x][master] → [MobileCore][MMA][Onboarding]
You need to log in before you can comment on or make changes to this bug.