Closed
Bug 1391359
Opened 7 years ago
Closed 7 years ago
Cleanup timestamp computation in nsAppStartup.cpp
Categories
(Toolkit :: Startup and Profile System, enhancement, P1)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: gfritzsche)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
|
3.31 KB,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
Looking through the startup module for another bug, i noticed that ComputeAbsoluteTimestamp() takes parameters but never uses them: https://dxr.mozilla.org/mozilla-central/rev/63ca686c3f1e870649b6d9c559973d100573aec2/toolkit/components/startup/nsAppStartup.cpp#130
|
Assignee | |
Comment 1•7 years ago
|
||
This 1) removes the unused parameters and 2) gives the function static linkage as its only used in this file.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8898409 [details] [diff] [review] Cleanup timestamp computation in nsAppStartup.cpp Gabriele, based on bug 793735 it looks like you could review? It should just be minor cleanup.
Attachment #8898409 -
Flags: review?(gsvelto)
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [measurement:client]
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8898409 [details] [diff] [review] Cleanup timestamp computation in nsAppStartup.cpp Review of attachment 8898409 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, those parameters were probably a leftover of an earlier version of the patch and nobody noticed them... IIRC the reason for using static values within the function was to set some kind of "fixed" reference for that pseudo-absolute time.
Attachment #8898409 -
Flags: review?(gsvelto) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P1
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/138870a2328f Cleanup timestamp computation in nsAppStartup.cpp. r=gsvelto
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/138870a2328f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•