Remove uploadsymbols target and related

NEW
Unassigned

Status

Firefox Build System
General
11 months ago
5 months ago

People

(Reporter: ted, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Now that all of our nightlies are built in Taskcluster, we're no longer using the uploadsymbols target for anything. It was used by Buildbot nightly builds to upload symbols to the symbol server, but Taskcluster builds use a separate upload-symbols task.

We can remove the uploadsymbols target:
https://dxr.mozilla.org/mozilla-central/rev/63ca686c3f1e870649b6d9c559973d100573aec2/Makefile.in#297

All traces of the `SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE` mentioned there:
https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE

except for the bits in https://dxr.mozilla.org/mozilla-central/source/taskcluster/docker/upload-symbols and https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/tools/upload_symbols.py

And anything that contains UPLOAD_SYMBOLS or uploadsymbols in moz-automation.mk:
https://dxr.mozilla.org/mozilla-central/source/build/moz-automation.mk
Landing bug 1422735 broke symbol uploads (bug 1424236). While looking into this I noticed that the Windows nightly *builds* had burned, because they still run `make uploadsymbols`, even though there's also an upload-symbols task that runs after the build to upload the symbols! Apparently we had worked around this for Linux builds in docker-worker but not for Windows builds:
https://dxr.mozilla.org/mozilla-central/rev/457b0fe91e0d49a5bc35014fb6f86729cd5bac9b/taskcluster/scripts/builder/build-linux.sh#46
(Reporter)

Updated

7 months ago
Assignee: nobody → ted
I'm just going to disable this in Windows builds until Thunderbird stops using this stuff, then we can rip it all out.
Assignee: ted → nobody
(Reporter)

Updated

7 months ago
Depends on: 1424323
Hi! I would like to work on this bug. I've taken a look at the links. We need to remove the requested code and all pieces of code that depend on it from the mentioned files. Do I understand correctly? Further I didn't quite understand the Windows builds part. Could you please direct me to any resources? Sorry, I'm fairly new to this. Thanks!

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.