Closed Bug 1391395 Opened 4 years ago Closed 4 years ago
Update awesomebar "Go" button for dark theme
Screenshot attached. macOS Nightly 57.0a1 2017-08-17.
Assignee: nobody → dao+bmo
Priority: -- → P1
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Comment on attachment 8900133 [details] Bug 1391395 - Consolidate Go button styling. https://reviewboard.mozilla.org/r/171528/#review177358 I couldnt get this to apply so might need a rebase (I just patched browser.inc myself to test). I didnt see this in any specs but this is far better and a nice cleanup on the original code
Attachment #8900133 - Flags: review?(dharvey) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/70694b2544b2 Consolidate Go button styling. r=daleharvey
This looks way better, thanks! I must mention that #058b00 looks quite out of place and should likely match the nav bar border color. I'll let you all prioritize that (maybe in a separate bug?), thanks!
(In reply to Ashish Vijayaram [:ashish] from comment #5) > This looks way better, thanks! I must mention that #058b00 looks quite out > of place and should likely match the nav bar border color. I'll let you all > prioritize that (maybe in a separate bug?), thanks! Feel free to file a new bug.
I have reproduced this bug with Nightly 57.0a1(2017-08-17) on Windows 8.1 ! This bug's fix is Verified with latest Nightly 57.0a1! Build ID 20170828100127 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170823]
You need to log in before you can comment on or make changes to this bug.